From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM: tegra: add Acer Chromebook 13 device tree
Date: Wed, 13 Aug 2014 11:10:08 -0600 [thread overview]
Message-ID: <53EB9BF0.9010002@wwwdotorg.org> (raw)
In-Reply-To: <1407894967-18300-1-git-send-email-dgreid@chromium.org>
On 08/12/2014 07:56 PM, Dylan Reid wrote:
> The Acer Chromebook 13, codenamed "Big", contains an NVIDIA tegra124
> processor and is similar to the Venice2 reference platform.
>
> The keyboard, USB 2, audio, HDMI, sdcard and emmc have been tested
> and work on the 1366x768 models. I haven't tried on the HD systems
> yet.
>
> WiFi does not yet work, it needs at least some PMIC changes to enable
> the 32k clock.
>
> The elan trackpad is not yet functional but hopefully will be soon as
> there are patches under review.
>
> There is also an issue on reboot because the TPM isn't reset. It will
> cause the stock firmware to enter recovery mode. This can be worked
> around by an EC-reset, press refresh and power at the same time.
> diff --git a/arch/arm/boot/dts/tegra124-big.dts b/arch/arm/boot/dts/tegra124-big.dts
I think we need to include the SKU name in the filename and compatible
value below, or at least plan out that for other SKUs, we'll add the SKU
name on.
> +/ {
> + model = "Google Big";
> + compatible = "google,nyan-big", "nvidia,tegra124";
I think it'd be more user-friendly if the filename and compatible value
more obviously tied to the end-user-visible product name.
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + lid {
> + label = "Lid";
> + gpios = <&gpio TEGRA_GPIO(R, 4) GPIO_ACTIVE_LOW>;
> + linux,input-type = <5>;
> + linux,code = <0>;
Aren't there #defines for the 5 and 0 there?
> + sound {
> + compatible = "nvidia,tegra-audio-max98090-venice2",
> + "nvidia,tegra-audio-max98090";
> + nvidia,model = "NVIDIA Tegra Venice2";
Those strings should all use the same board name as the filename,
compatible value, and model of the root node. Based on the content in
your patch, I would expect:
compatible = "nvidia,tegra-audio-max98090-big",
"nvidia,tegra-audio-max98090";
nvidia,model = "Google Big";
In particular, nvidia,model is used to index into
/var/lib/alsa/asound.state by name, so it needs to be unique for each board.
> + nvidia,mic-det-gpios = <&gpio TEGRA_GPIO(R, 7)
> + GPIO_ACTIVE_HIGH>;
That property doesn't (yet) exist in the binding/code upstream. It could
obviously be added.
next prev parent reply other threads:[~2014-08-13 17:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 1:56 [PATCH 1/2] ARM: tegra: add Acer Chromebook 13 device tree Dylan Reid
2014-08-13 8:53 ` Thierry Reding
2014-08-13 16:23 ` Andrew Bresticker
2014-08-13 16:51 ` Olof Johansson
2014-08-13 16:57 ` Stephen Warren
2014-08-13 16:51 ` Stephen Warren
2014-08-13 16:55 ` Olof Johansson
2014-08-13 17:04 ` Andrew Bresticker
2014-08-13 17:12 ` Stephen Warren
2014-08-13 17:17 ` Andrew Bresticker
2014-08-13 18:42 ` Dylan Reid
2014-08-13 17:10 ` Stephen Warren [this message]
2014-08-13 17:23 ` Olof Johansson
2014-08-13 17:31 ` Stephen Warren
2014-08-13 17:37 ` Olof Johansson
2014-08-13 20:17 ` Stephen Warren
2014-08-13 19:07 ` Dylan Reid
2014-08-13 19:56 ` Stephen Warren
2014-08-14 8:40 ` Dylan Reid
2015-01-13 17:49 ` Tomeu Vizoso
2015-01-14 0:32 ` Dylan Reid
2015-01-14 7:02 ` Tomeu Vizoso
2015-01-15 7:50 ` Thierry Reding
2015-01-15 12:18 ` Tomeu Vizoso
2015-01-15 17:18 ` Stephen Warren
2015-01-19 9:01 ` Tomeu Vizoso
2015-01-19 19:29 ` Andrew Bresticker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EB9BF0.9010002@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox