From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/5] of: Add descriptions of thermtrip properties to Tegra PMC bindings
Date: Wed, 20 Aug 2014 14:16:49 -0600 [thread overview]
Message-ID: <53F50231.5010605@wwwdotorg.org> (raw)
In-Reply-To: <1407933685-12404-2-git-send-email-mperttunen@nvidia.com>
On 08/13/2014 06:41 AM, Mikko Perttunen wrote:
> Hardware-triggered thermal reset requires configuring the I2C
> reset procedure. This configuration is read from the device tree,
> so document the relevant properties in the binding documentation.
> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.txt
> +Hardware-triggered thermal reset:
> +On Tegra30, Tegra114 and Tegra124, if the 'i2c-thermtrip' subnode exists,
> +hardware-triggered thermal reset will be enabled.
"will be enabled" sounds like SW behaviour, whereas DT is suppose to
describe HW, and leave SW to define its own behaviour. I would suggest:
Optional sub-nodes:
i2c-thermtrip: Describes how to power off the system in the event of a
thermal emergency.
> +Required properties for hardware-triggered thermal reset (inside 'i2c-thermtrip'):
Simpler might be:
Required properties for i2c-thermtrip node:
> +- nvidia,pmu : Phandle to power management unit / PMIC handling poweroff
> +- nvidia,reg-addr : I2C register address to write poweroff command to
> +- nvidia,reg-data : Poweroff command to write to PMU
Why are both the PMU/PMIC phandle and the register address/data
required? I thought the purpose of having the phandle was to allow the
register address and data to be queried from the PMU/PMIC driver.
To me, it seems much simpler to get rid of the phandle and just
hard-code the I2C bus number, address, and data into this node, rather
than having to go query it from the PMU/PMIC driver, then find the I2C
controller, then query it for its ID (and hope that all HW modules that
talk to I2C controllers directly use the same numbering scheme...)
next prev parent reply other threads:[~2014-08-20 20:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 12:41 [PATCH v2 0/5] Thermal reset support in PMC Mikko Perttunen
2014-08-13 12:41 ` [PATCH v2 1/5] of: Add descriptions of thermtrip properties to Tegra PMC bindings Mikko Perttunen
2014-08-20 20:16 ` Stephen Warren [this message]
2014-08-21 6:58 ` Thierry Reding
2014-08-21 15:38 ` Stephen Warren
2014-08-21 16:53 ` Thierry Reding
2014-08-21 17:54 ` Stephen Warren
2014-09-05 9:50 ` Mikko Perttunen
2014-09-05 18:48 ` Stephen Warren
2014-08-20 20:22 ` Stephen Warren
2014-08-13 12:41 ` [PATCH v2 2/5] of: Add nvidia, controller-id property to Tegra I2C bindings Mikko Perttunen
2014-08-20 20:19 ` [PATCH v2 2/5] of: Add nvidia,controller-id " Stephen Warren
2014-08-21 7:05 ` Thierry Reding
2014-08-21 15:41 ` Stephen Warren
2014-08-13 12:41 ` [PATCH v2 3/5] ARM: tegra124: Add I2C controller ids to device tree Mikko Perttunen
2014-08-13 12:41 ` [PATCH v2 4/5] ARM: tegra: Add PMC thermtrip programming to Jetson TK1 " Mikko Perttunen
2014-08-13 12:41 ` [PATCH v2 5/5] ARM: tegra: Add thermal reset (thermtrip) support to PMC Mikko Perttunen
2014-08-20 20:25 ` Stephen Warren
2014-08-21 13:11 ` Mikko Perttunen
2014-08-21 15:40 ` Stephen Warren
2014-08-22 12:55 ` Mikko Perttunen
2014-08-14 11:26 ` [PATCH v2 0/5] Thermal reset support in PMC Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F50231.5010605@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox