From: afaerber@suse•de (Andreas Färber)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv3] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250
Date: Thu, 21 Aug 2014 12:32:47 +0200 [thread overview]
Message-ID: <53F5CACF.4050600@suse.de> (raw)
In-Reply-To: <53F54D86.9070601@samsung.com>
Hello,
Am 21.08.2014 03:38, schrieb Chanwoo Choi:
> On 08/20/2014 10:38 PM, edubezval at gmail.com wrote:
>> On Tue, Aug 19, 2014 at 7:52 PM, Chanwoo Choi <cw00.choi@samsung•com> wrote:
>>> diff --git a/drivers/thermal/samsung/exynos_tmu_data.c b/drivers/thermal/samsung/exynos_tmu_data.c
>>> index aa8e0de..8cd609c 100644
>>> --- a/drivers/thermal/samsung/exynos_tmu_data.c
>>> +++ b/drivers/thermal/samsung/exynos_tmu_data.c
>>> @@ -95,6 +95,8 @@ static const struct exynos_tmu_registers exynos3250_tmu_registers = {
>>> .triminfo_data = EXYNOS_TMU_REG_TRIMINFO,
>>> .triminfo_25_shift = EXYNOS_TRIMINFO_25_SHIFT,
>>> .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,
>>> + .triminfo_ctrl[0] = EXYNOS_TMU_TRIMINFO_CON1,
>>> + .triminfo_ctrl[1] = EXYNOS_TMU_TRIMINFO_CON2,
>>> .tmu_ctrl = EXYNOS_TMU_REG_CONTROL,
>>> .test_mux_addr_shift = EXYNOS4412_MUX_ADDR_SHIFT,
>>> .buf_vref_sel_shift = EXYNOS_TMU_REF_VOLTAGE_SHIFT,
>>> @@ -160,8 +162,11 @@ static const struct exynos_tmu_registers exynos3250_tmu_registers = {
>>> .temp_level = 95, \
>>> }, \
>>> .freq_tab_count = 2, \
>>> + .triminfo_reload[0] = 0x1, \
>>> + .triminfo_reload[1] = 0x11, \
>>
>> What does 0x1 mean? How about 0x11?
>
> The bit of 'RELOAD' field in TRIMINFO_CONTROL register is [0].
> and The bit of 'AC Time' field in TRIMINFO_CONTROL register is [5:4].
>
> 0x1 means that set RELOAD field.
> 0x11 means that set RELOAD field and ACTIME field.
Might be a good idea to use #defines for 0x1 and 0x10 then?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
next prev parent reply other threads:[~2014-08-21 10:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 11:57 [PATCH] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250 Chanwoo Choi
2014-08-19 12:07 ` [PATCHv2] " Chanwoo Choi
2014-08-19 12:28 ` edubezval at gmail.com
2014-08-19 23:47 ` Chanwoo Choi
2014-08-19 23:52 ` [PATCHv3] " Chanwoo Choi
2014-08-20 4:51 ` amit daniel kachhap
2014-08-20 4:52 ` Chanwoo Choi
2014-08-20 12:14 ` Bartlomiej Zolnierkiewicz
2014-08-20 13:38 ` edubezval at gmail.com
2014-08-21 1:38 ` Chanwoo Choi
2014-08-21 10:32 ` Andreas Färber [this message]
2014-08-21 16:24 ` Chanwoo Choi
2014-08-20 4:24 ` [PATCH] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440 Chanwoo Choi
2014-08-20 5:03 ` amit daniel kachhap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F5CACF.4050600@suse.de \
--to=afaerber@suse$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox