Subject: Re: [PATCH v2 2/4] dt-bindings: npu: rockchip,rk3588-rknn-core: Add RK3568 support

From: Krzysztof Kozlowski <[email-masked]>
Date: Fri, 29 May 2026 18:18:16 +0200

On 29/05/2026 17:58, MidG971 wrote:
> From: Midgy BALON <[email-masked]>
> 
> Add rockchip,rk3568-rknn-core to the compatible enum, document the
> new rockchip,pmu phandle that RK3568 needs for the NPU NOC bus de-idle
> sequence, and make sram-supply only required on RK3588 (RK3568 has no
> NPU SRAM rail).
> 
> The driver supports both RK3568 and RK3588 RKNN cores; the binding now
> documents both. The rockchip,pmu phandle is consumed by the driver to
> issue PMU register writes (BUS_IDLE_SFTCON0, NOC_AUTO_CON0,

You need to start explaining the hardware, not drivers.

> PWR_GATE_SFTCON, BUS_IDLE_ST) on RK3568 only.
> 
> Signed-off-by: Midgy BALON <[email-masked]>
> ---
>  .../npu/rockchip,rk3588-rknn-core.yaml         | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml b/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml
> index caca2a490..6582a0c5c 100644
> --- a/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml
> +++ b/Documentation/devicetree/bindings/npu/rockchip,rk3588-rknn-core.yaml
> @@ -21,6 +21,7 @@ properties:
>  
>    compatible:
>      enum:
> +      - rockchip,rk3568-rknn-core
>        - rockchip,rk3588-rknn-core
>  
>    reg:
> @@ -50,6 +51,13 @@ properties:
>  
>    npu-supply: true
>  
> +  rockchip,pmu:
> +    : /schemas/types.yaml#/definitions/phandle

I don't think you tested this.

Best regards,
Krzysztof