From: inki.dae@samsung•com (Inki Dae)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RFC v2 3/8] component: add support for component match array
Date: Mon, 01 Sep 2014 11:47:41 +0900 [thread overview]
Message-ID: <5403DE4D.3090509@samsung.com> (raw)
In-Reply-To: <20140830213349.GE30401@n2100.arm.linux.org.uk>
On 2014? 08? 31? 06:33, Russell King - ARM Linux wrote:
> On Thu, Jul 03, 2014 at 12:26:39AM +0900, Inki Dae wrote:
>> 2014-07-01 23:22 GMT+09:00 Russell King - ARM Linux <linux@arm•linux.org.uk>:
>>> On Thu, Jun 26, 2014 at 03:46:01PM +0100, Russell King - ARM Linux wrote:
>>>> On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
>>>>> Hi Russell,
>>>>>
>>>>> On Tue, Jun 24, 2014 at 9:29 PM, Russell King
>>>>> <rmk+kernel@arm•linux.org.uk> wrote:
>>>>> [...]
>>>>>> +/*
>>>>>> + * Add a component to be matched.
>>>>>> + *
>>>>>> + * The match array is first created or extended if necessary.
>>>>>> + */
>>>>>> +void component_match_add(struct device *dev, struct component_match **matchptr,
>>>>>> + int (*compare)(struct device *, void *), void *compare_data)
>>>>>> +{
>>>>>> + struct component_match *match = *matchptr;
>>>>>> +
>>>>>> + if (IS_ERR(match))
>>>>>> + return;
>>>>>> +
>>>>>> + if (!match || match->num == match->alloc) {
>>>>>> + size_t new_size = match ? match->alloc + 16 : 15;
>>>>>> +
>>>>>> + match = component_match_realloc(dev, match, new_size);
>>>>>> +
>>>>>> + *matchptr = match;
>>>>>> +
>>>>>> + if (IS_ERR(match))
>>>>>> + return;
>>>>>> + }
>>>>>> +
>>>>>> + match->compare[match->num].fn = compare;
>>>>>> + match->compare[match->num].data = compare_data;
>>>>>> + match->num++;
>>>>>> +}
>>>>>
>>>>> component_match_add should be exported.
>>>>
>>>> Fixed, thanks.
>>>
>>> As there's no further comments, and Inki Dae has not responded, I'm
>>
>> It's has been just a week. I will check and look into your patch
>> series. I think Exynos drm should also be considered for the use of
>> component match array.
>
> It has now been almost two months. What's happening on this?
>
> Please note that I'm planning to push the rest of the component updates
> during the next merge window, which will result in unconverted drivers
> breaking.
>
Sorry for this. I was busy with other works. I will update and post it
until this week.
Thanks,
Inki Dae
> Thanks.
>
next prev parent reply other threads:[~2014-09-01 2:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 19:28 [PATCH RFC v2 0/8] component helper improvements Russell King - ARM Linux
2014-06-24 19:28 ` [PATCH RFC v2 1/8] component: fix missed cleanup in case of devres failure Russell King
2014-06-24 19:29 ` [PATCH RFC v2 2/8] component: ignore multiple additions of the same component Russell King
2014-06-24 19:29 ` [PATCH RFC v2 3/8] component: add support for component match array Russell King
2014-06-26 12:34 ` Philipp Zabel
2014-06-26 14:46 ` Russell King - ARM Linux
2014-07-01 14:22 ` Russell King - ARM Linux
2014-07-02 15:26 ` Inki Dae
2014-07-02 16:15 ` Russell King - ARM Linux
2014-08-30 21:33 ` Russell King - ARM Linux
2014-09-01 2:47 ` Inki Dae [this message]
2014-06-24 19:29 ` [PATCH RFC v2 4/8] drm: msm: update to use component match support Russell King
2014-06-24 19:29 ` [PATCH RFC v2 5/8] imx-drm: " Russell King
2014-06-24 19:29 ` [PATCH RFC v2 6/8] component: remove old add_components method Russell King
2014-06-24 19:29 ` [PATCH RFC v2 7/8] component: move check for unbound master into try_to_bring_up_masters() Russell King
2014-06-24 19:29 ` [PATCH RFC v2 8/8] component: track components via array rather than list Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5403DE4D.3090509@samsung.com \
--to=inki.dae@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox