From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 00/26] genirq: fix use of irq_find_mapping outside of legal RCU context
Date: Wed, 03 Sep 2014 13:21:07 +0100 [thread overview]
Message-ID: <540707B3.4050305@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1409031409160.3333@nanos>
[Dropping linux at openrisc.net from the CC list]
On 03/09/14 13:09, Thomas Gleixner wrote:
> On Wed, 3 Sep 2014, Jason Cooper wrote:
>
>> On Wed, Aug 27, 2014 at 10:33:44AM +0100, Marc Zyngier wrote:
>>> Hi Thomas,
>>>
>>> On Tue, Aug 26 2014 at 10:34:51 pm BST, Thomas Gleixner <tglx@linutronix•de> wrote:
>>>> On Tue, 26 Aug 2014, Marc Zyngier wrote:
>>>>
>>>>> A number of irqchip drivers are directly calling irq_find_mapping,
>>>>> which may use a rcu_read_lock call when walking the radix tree.
>>>>>
>>>>> Turns out that if you hit that point with CONFIG_PROVE_RCU enabled,
>>>>> the kernel will shout at you, as using RCU in this context may be
>>>>> illegal (specially if coming from the idle state, where RCU would be
>>>>> in a quiescent state).
>>>>>
>>>>> A possible fix would be to wrap calls to irq_find_mapping into a
>>>>> RCU_NONIDLE macro, but that really looks ugly.
>>>>>
>>>>> This patch series introduce another generic IRQ entry point
>>>>> (handle_domain_irq), which has the exact same behaviour as handle_IRQ
>>>>> (as defined on arm, arm64 and openrisc), except that it also takes a
>>>>> irq_domain pointer. This allows the logical IRQ lookup to be done
>>>>> inside the irq_{enter,exit} section, which contains a
>>>>> rcu_irq_{enter,exit}, making it safe.
>>>>
>>>> Looks good. Should this be routed to the genirq tree?
>>>
>>> I'm happy for you to take this series, provided the architecture
>>> maintainers agree on it (I'm still to hear from the openrisc guys, and
>>> their mailing-list seems to positively hate my guts).
>>
>> I think everyone's had a chance to look over it by now. Thomas, shall I
>> take the series?
>
> Yes please.
Do you want a pull request? Or are you picking up the patches from the ML?
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-09-03 12:21 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 10:03 [PATCH v2 00/26] genirq: fix use of irq_find_mapping outside of legal RCU context Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 01/26] genirq: add irq_domain-aware core IRQ handler Marc Zyngier
2014-08-26 17:42 ` Stephen Boyd
2014-08-26 18:07 ` Marc Zyngier
2014-08-26 18:46 ` Stephen Boyd
2014-08-26 19:05 ` Stephen Boyd
2014-09-01 15:22 ` Russell King - ARM Linux
2014-08-26 10:03 ` [PATCH v2 02/26] arm64: convert handle_IRQ to use __handle_domain_irq Marc Zyngier
2014-08-26 16:51 ` Catalin Marinas
2014-08-26 16:58 ` Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 03/26] ARM: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 04/26] openrisc: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 05/26] irqchip: GIC: convert to handle_domain_irq Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 06/26] irqchip: armada-370-xp: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 07/26] irqchip: clps711x: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 08/26] irqchip: mmp: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 09/26] irqchip: mxs: " Marc Zyngier
2014-08-27 6:38 ` Shawn Guo
2014-08-26 10:03 ` [PATCH v2 10/26] irqchip: orion: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 11/26] irqchip: s3c24xx: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 12/26] irqchip: sirfsoc: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 13/26] irqchip: sun4i: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 14/26] irqchip: versatile-fpga: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 15/26] irqchip: vic: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 16/26] irqchip: vt8500: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 17/26] irqchip: zevio: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 18/26] irqchip: GICv3: " Marc Zyngier
2014-08-26 10:03 ` [PATCH v2 19/26] irqchip: atmel-aic: " Marc Zyngier
2014-09-01 9:32 ` Nicolas Ferre
2014-09-01 10:16 ` Boris BREZILLON
2014-08-26 10:03 ` [PATCH v2 20/26] irqchip: atmel-aic5: " Marc Zyngier
2014-09-01 9:33 ` Nicolas Ferre
2014-09-01 9:51 ` Boris BREZILLON
2014-08-26 10:03 ` [PATCH v2 21/26] irqchip: or1k-pic: " Marc Zyngier
2014-08-27 17:09 ` Stefan Kristiansson
2014-08-26 10:03 ` [PATCH v2 22/26] ARM: imx: avic: " Marc Zyngier
2014-08-27 6:40 ` Shawn Guo
2014-08-26 10:03 ` [PATCH v2 23/26] ARM: imx: tzic: " Marc Zyngier
2014-08-27 6:40 ` Shawn Guo
2014-08-26 10:03 ` [PATCH v2 24/26] ARM: omap2: irq: " Marc Zyngier
2014-08-26 20:57 ` Tony Lindgren
2014-08-26 10:03 ` [PATCH v2 25/26] arm64: get rid of handle_IRQ Marc Zyngier
2014-08-26 16:53 ` Catalin Marinas
2014-08-26 10:03 ` [PATCH v2 26/26] openrisc: " Marc Zyngier
2014-08-26 21:34 ` [PATCH v2 00/26] genirq: fix use of irq_find_mapping outside of legal RCU context Thomas Gleixner
2014-08-27 9:33 ` Marc Zyngier
2014-09-03 12:04 ` Jason Cooper
2014-09-03 12:09 ` Thomas Gleixner
2014-09-03 12:21 ` Marc Zyngier [this message]
2014-09-03 12:25 ` Thomas Gleixner
2014-09-03 12:37 ` Jason Cooper
2014-09-03 12:40 ` Marc Zyngier
2014-09-03 12:37 ` Marc Zyngier
2014-09-03 13:18 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540707B3.4050305@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox