From: tomeu.vizoso@collabora•com (Tomeu Vizoso)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v8 4/7] clk: use struct clk only for external API
Date: Thu, 04 Sep 2014 15:34:47 +0200 [thread overview]
Message-ID: <54086A77.6050708@collabora.com> (raw)
In-Reply-To: <5407A82B.7000602@codeaurora.org>
On 09/04/2014 01:45 AM, Stephen Boyd wrote:
> On 09/01/14 08:34, Tomeu Vizoso wrote:
>
>>
>> NOTE: with this patch, clk_get_parent() behaves like clk_get(), i.e. it
>> needs to be matched with a clk_put(). Otherwise, memory will leak.
>>
> [...]
>> }
>> +EXPORT_SYMBOL_GPL(clk_provider_get_parent);
>> +
>> +/**
>> + * clk_get_parent - return the parent of a clk
>> + * @clk_user: the clk whose parent gets returned
>> + *
>> + * Simply returns clk->parent. Returns NULL if clk is NULL.
>
> We should at least document here that clk_put() is expected to be called
> when it's not being used.
Good point.
> I wonder why it's this way though. Why can't
> every clk_core have a private clk pointer to it's parent that's created
> during registration time? Then we just hand that out for
> clk_get_parent() and destroy it when the clk_core is freed?
Well, that wouldn't be a per-user clock any more, right? I see though
how it would be desirable not to burden the caller with having to free
the per-user clk.
Thanks,
Tomeu
prev parent reply other threads:[~2014-09-04 13:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 15:29 [PATCH v8 0/7] Per-user clock constraints Tomeu Vizoso
2014-09-01 15:29 ` [PATCH v8 1/7] clk: Add temporary mapping to the existing API Tomeu Vizoso
2014-09-01 15:29 ` [PATCH v8 2/7] ASoC: mxs-saif: fix mixed use of public and provider clk API Tomeu Vizoso
2014-09-01 15:34 ` [PATCH v8 4/7] clk: use struct clk only for external API Tomeu Vizoso
2014-09-01 15:34 ` [PATCH v8 5/7] clk: per-user clock accounting for debug Tomeu Vizoso
2014-09-01 15:34 ` [PATCH v8 6/7] clk: Add floor and ceiling constraints to clock rates Tomeu Vizoso
2014-09-03 0:13 ` Mike Turquette
2014-09-03 14:14 ` Tomeu Vizoso
2014-09-01 15:34 ` [PATCH v8 7/7] clk: Warn of unbalanced clk_prepare() calls Tomeu Vizoso
2014-09-03 23:45 ` [PATCH v8 4/7] clk: use struct clk only for external API Stephen Boyd
2014-09-04 13:34 ` Tomeu Vizoso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54086A77.6050708@collabora.com \
--to=tomeu.vizoso@collabora$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox