From: caesar.wang@rock-chips•com (Caesar Wang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288
Date: Wed, 10 Sep 2014 10:49:05 +0800 [thread overview]
Message-ID: <540FBC21.2090504@rock-chips.com> (raw)
In-Reply-To: <3426113.Zcq8V2S7cg@diego>
Hi Heiko,
? 2014?09?09? 19:37, Heiko St?bner ??:
> Am Mittwoch, 3. September 2014, 10:10:38 schrieb Caesar Wang:
>> Signed-off-by: Caesar Wang <caesar.wang@rock-chips•com>
>> ---
>> arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index 36be7bb..3d672e3 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -224,6 +224,17 @@
>> status = "disabled";
>> };
>>
>> + tsadc: tsadc at ff280000 {
> please keep the list of nodes sorted by register address. So when looking at
> my v3.18-next/dts branch, it should be after uart4: serial at ff1c0000 and before
> usb_host0_ehci: usb at ff500000 .
>
oh...,I will fix it.
>> + compatible = "rockchip,rk3288-tsadc";
>> + reg = <0xff280000 0x100>;
>> + interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru SCLK_TSADC>, <&cru PCLK_TSADC>;
>> + clock-names = "tsadc", "apb_pclk";
>> + pinctrl-names = "default";
>> + pinctrl-1 = <&tsadc_int>;
>> + status = "disabled";
>> + };
>> +
>> /* NOTE: ohci at ff520000 doesn't actually work on hardware */
>>
>> usb_hsic: usb at ff5c0000 {
>> @@ -611,5 +622,12 @@
>> rockchip,pins = <5 15 3 &pcfg_pull_none>;
>> };
>> };
>> +
>> + tsadc {
>> + tsadc_int: tsadc-int {
>> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>;
>> + };
>> + };
> After looking this up in the schematics I see that this is the
> overtemperature-protection output pin ... labeled OTP_OUT.
> So I'd think the pinconfig should reflect this pin-name, especially as tsadc-int
> suggests, that this would be an interrupt leading into the tsadc, while in
> fact it is an output to a separate circuit.
>
Maybe,I guess your mean as the follows .
Please correct it and Laugh out if I got it wrong.
tsadc {
otp_out: otp-out {
rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>;
};
tsadc_int: tsadc-int {
rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>;
};
};
Then,I deal with the otp_out in thermal driver.
I believe The "otp_out" will restart board if it's a high active.
tsadc_int: tsadc-int {
+ rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>;
+ };
But,I think the about will be implemented in thermal driver.
> Heiko
>
>
>
--
Best regards,
Caesar
next prev parent reply other threads:[~2014-09-10 2:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 2:10 [PATCH v4 0/4] Rockchip soc thermal driver Caesar Wang
2014-09-03 2:10 ` [PATCH v4 1/4] thermal: rockchip: add driver for thermal Caesar Wang
2014-08-30 20:09 ` Eduardo Valentin
2014-09-10 4:39 ` Caesar Wang
2014-09-10 12:46 ` Eduardo Valentin
2014-09-10 13:21 ` Caesar Wang
2014-09-17 7:29 ` Caesar Wang
2014-09-04 17:06 ` Dmitry Torokhov
2014-09-05 0:33 ` Caesar Wang
2014-09-03 2:10 ` [PATCH v4 2/4] dt-bindings: document Rockchip thermal Caesar Wang
2014-09-03 8:07 ` Heiko Stübner
2014-09-04 1:02 ` Caesar Wang
2014-09-09 2:27 ` Zhang Rui
2014-09-09 11:35 ` Heiko Stübner
2014-09-09 15:09 ` Eduardo Valentin
2014-09-10 1:02 ` Zhang Rui
2014-09-10 1:14 ` edubezval at gmail.com
2014-09-10 7:24 ` Heiko Stübner
2014-09-11 2:36 ` Zhang Rui
2014-09-11 12:18 ` Eduardo Valentin
2014-09-11 12:32 ` Arnd Bergmann
2014-09-11 15:53 ` Eduardo Valentin
2014-09-16 7:23 ` Zhang Rui
2014-09-16 7:45 ` Zhang Rui
2014-09-03 2:10 ` [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288 Caesar Wang
2014-09-09 11:37 ` Heiko Stübner
2014-09-10 2:49 ` Caesar Wang [this message]
2014-09-11 13:58 ` Heiko Stübner
2014-09-03 2:10 ` [PATCH v4 4/4] ARM: dts: enable Thermal on rk3288-evb board Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540FBC21.2090504@rock-chips.com \
--to=caesar.wang@rock-chips$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox