From: Ray Jui <ray.jui@broadcom•com>
To: Wolfram Sang <wsa@the-dreams•de>
Cc: Mark Rutland <mark.rutland@arm•com>,
devicetree@vger•kernel.org,
Lori Hikichi <lori.hikichi@broadcom•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Shivaraj Shetty <sshetty1@broadcom•com>,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom•com>,
linux-kernel@vger•kernel.org,
Icarus Chau <icarus.chau@broadcom•com>,
Rob Herring <robh+dt@kernel•org>,
bcm-kernel-feedback-list@broadcom•com, linux-i2c@vger•kernel.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v1 1/1] i2c: iproc: Add i2c repeated start capability
Date: Tue, 3 Sep 2019 16:11:16 -0700 [thread overview]
Message-ID: <540c4e2d-0dd5-5260-30b2-e1589b279d71@broadcom.com> (raw)
In-Reply-To: <20190831094940.GA1138@kunai>
On 8/31/19 2:49 AM, Wolfram Sang wrote:
> Hi Ray,
>
>>> With all the limitations in place, I wonder if it might be easier to
>>> implement an smbus_xfer callback instead? What is left that makes this
>>> controller more than SMBus and real I2C?
>>>
>>
>> Right. But what is the implication of using smbus_xfer instead of
>> master_xfer in our driver?
>>
>> Does it mean it will break existing functions of the i2c app that our
>> customers developed based on i2cdev (e.g., I2C_RDWR)?
>
> If the customers uses I2C_RDWR (and it cannot be mapped to i2c_smbus_*
> calls) then this is an indication that there is some I2C functionality
> left which the HW can provide. I'd be interested which one, though.
>
>>
>> 1) Does
>
> Maybe you wanted to describe it here and it got accidently cut off? >
I think you are right that the controller does not seem to support
additional I2C features in addition to SMBUS.
However, my concern of switching to the smbus_xfer API is:
1) Some customers might have used I2C_RDWR based API from i2cdev.
Changing from master_xfer to smbus_xfer may break the existing
applications that are already developed.
2) The sound subsystem I2C regmap based implementation seems to be using
i2c_ based API instead of smbus_ based API. Does this mean this will
also break most of the audio codec drivers with I2C regmap API based usage?
Thanks,
Ray
> Regards,
>
> Wolfram
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-03 23:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 4:09 [PATCH v1 1/1] i2c: iproc: Add i2c repeated start capability Rayagonda Kokatanur
2019-08-12 17:33 ` Ray Jui
2019-08-29 20:41 ` Wolfram Sang
2019-08-30 12:56 ` Wolfram Sang
2019-08-30 18:35 ` Ray Jui
2019-08-31 9:49 ` Wolfram Sang
2019-09-03 23:11 ` Ray Jui [this message]
2019-09-04 21:37 ` Wolfram Sang
2019-09-24 17:23 ` Ray Jui
2019-09-24 18:57 ` Wolfram Sang
2019-09-24 22:23 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540c4e2d-0dd5-5260-30b2-e1589b279d71@broadcom.com \
--to=ray.jui@broadcom$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=icarus.chau@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lori.hikichi@broadcom$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=rayagonda.kokatanur@broadcom$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sshetty1@broadcom$(echo .)com \
--cc=wsa@the-dreams$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox