From: pramod.gurav@smartplayin•com (Pramod Gurav)
To: linux-arm-kernel@lists•infradead.org
Subject: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver
Date: Sat, 13 Sep 2014 02:03:50 +0530 [thread overview]
Message-ID: <541358AE.6010504@smartplayin.com> (raw)
In-Reply-To: <20140912202942.GC25500@saruman.home>
On 13-09-2014 01:59 AM, Felipe Balbi wrote:
> Hi,
>
> On Sat, Sep 13, 2014 at 01:55:50AM +0530, Pramod Gurav wrote:
>>>>> + qdwc = devm_kzalloc(&pdev->dev, sizeof(*qdwc), GFP_KERNEL);
>>>>> + if (!qdwc)
>>>>> + return -ENOMEM;
>>>>> +
>>>>> + platform_set_drvdata(pdev, qdwc);
>>>>> +
>>>>> + qdwc->dev = &pdev->dev;
>>>>> +
>>>>> + qdwc->core_clk = devm_clk_get(qdwc->dev, "core");
>>>>> + if (IS_ERR(qdwc->core_clk)) {
>>>>> + dev_err(qdwc->dev, "failed to get core clock\n");
>>>>> + return PTR_ERR(qdwc->core_clk);
>>>>> + }
>>>>> +
>>>>> + qdwc->iface_clk = devm_clk_get(qdwc->dev, "iface");
>>>>> + if (IS_ERR(qdwc->iface_clk)) {
>>>>> + dev_dbg(qdwc->dev, "failed to get optional iface clock\n");
>>>>> + qdwc->iface_clk = NULL;
>>>>> + }
>>>>> +
>>>>> + qdwc->sleep_clk = devm_clk_get(qdwc->dev, "sleep");
>>>>> + if (IS_ERR(qdwc->sleep_clk)) {
>>>>> + dev_dbg(qdwc->dev, "failed to get optional sleep clock\n");
>>>>> + qdwc->sleep_clk = NULL;
>>>>> + }
>>>>> +
>>>>> + ret = clk_prepare_enable(qdwc->core_clk);
>>>>> + if (ret) {
>>>>> + dev_err(qdwc->dev, "failed to enable core clock\n");
>>>>> + goto err_core;
>>>>> + }
>>>>> +
>>>>> + ret = clk_prepare_enable(qdwc->iface_clk);
>>>>>
>>>> Should not we check if qdwc->iface_clk is valid?
>>>
>>> read the sources luke.
>> Now I read that its initialized to NULL in fail case but should we call
>> prepare_enable at all if its NULL?
>
> now read the source of clk_enable() and clk_prepare() ;-) NULL is a
> valid clock, it just returns 0. This is better than sprinkling IS_ERR()
> all over the place.
Seen that. I was wrong about IS_ERR. Thanks. :)
>
next prev parent reply other threads:[~2014-09-12 20:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 19:28 [Patch v9 0/3] DWC3 USB support for Qualcomm platform Andy Gross
2014-09-12 19:28 ` [Patch v9 1/3] usb: dwc3: qcom: Add device tree binding Andy Gross
2014-09-16 18:15 ` Jack Pham
2014-09-16 18:29 ` Felipe Balbi
2014-09-12 19:28 ` [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver Andy Gross
[not found] ` <CAMf-jSm2fPPstFD2h4-gG=MCDty34f-O0ooizDEKyQUd3+CxGQ@mail.gmail.com>
2014-09-12 20:20 ` Felipe Balbi
2014-09-12 20:25 ` Pramod Gurav
2014-09-12 20:29 ` Felipe Balbi
2014-09-12 20:33 ` Pramod Gurav [this message]
2014-09-12 19:28 ` [Patch v9 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver Andy Gross
2014-09-13 6:46 ` Kishon Vijay Abraham I
2014-09-14 2:24 ` Felipe Balbi
2014-09-15 6:37 ` Kishon Vijay Abraham I
2014-09-16 18:27 ` Jack Pham
2014-09-16 20:39 ` Andy Gross
2015-01-22 18:59 ` Jack Pham
2015-01-22 21:44 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541358AE.6010504@smartplayin.com \
--to=pramod.gurav@smartplayin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox