From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] BCM2835: Add I2S driver to device tree
Date: Wed, 17 Sep 2014 11:23:26 -0600 [thread overview]
Message-ID: <5419C38E.4010709@wwwdotorg.org> (raw)
In-Reply-To: <20140917164436.GJ7960@sirena.org.uk>
On 09/17/2014 10:44 AM, Mark Brown wrote:
> On Tue, Sep 16, 2014 at 07:53:09PM -0600, Stephen Warren wrote:
>> On 07/09/2014 02:50 AM, Mark Brown wrote:
>>> From: Mark Brown <broonie@linaro•org>
>
>>> + bcm2835_i2s: i2s at 7e203000 {
>>> + compatible = "brcm,bcm2835-i2s";
>>> + reg = <0x7e203000 0x20>,
>>> + <0x7e101098 0x02>;
>>> +
>>> + dmas = <&dma 2>,
>>> + <&dma 3>;
>>> + dma-names = "tx", "rx";
>>> + };
>
>> This node is already there (and even edited in this patch), so I dropped
>> that hunk.
>
> Right, not sure what went on with applying it upstream originally but it
> looks like git rebase didn't figure out what was going on well - the
> bcm2835_i2s is needed so we can reference the node. I'll probably get
> round to resending an incremental patch.
Oh right, I guess I did drop the addition of that label when I dropped
that node.
The board DT could doesn't necessarily require a label though; it could
just repeat the node name:
/ {
i2s at 7e203000 {
... extra properties
Still, it looks like we typically use labels to reference nodes in
bcm2835-*.dts, so adding the label would indeed be a good idea.
prev parent reply other threads:[~2014-09-17 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 8:50 [PATCH] BCM2835: Add I2S driver to device tree Mark Brown
2014-09-17 1:53 ` Stephen Warren
2014-09-17 16:44 ` Mark Brown
2014-09-17 17:23 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5419C38E.4010709@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox