From: caesar.wang@rock-chips•com (Caesar Wang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 2/4] dt-bindings: document Rockchip thermal
Date: Thu, 18 Sep 2014 10:33:05 +0800 [thread overview]
Message-ID: <541A4461.4080101@rock-chips.com> (raw)
In-Reply-To: <20140917201347.GD25297@core.coreip.homeip.net>
? 2014?09?18? 04:13, Dmitry Torokhov ??:
> On Wed, Sep 17, 2014 at 12:48:16PM -0700, Doug Anderson wrote:
>> Caesar,
>>
>> On Tue, Sep 16, 2014 at 8:59 PM, Caesar Wang <caesar.wang@rock-chips•com> wrote:
>>> This add the necessary binding documentation for the thermal
>>> found on Rockchip SoCs
>>>
>>> Signed-off-by: zhaoyifeng <zyf@rock-chips•com>
>>> Signed-off-by: Caesar Wang <caesar.wang@rock-chips•com>
>>> ---
>>> .../bindings/thermal/rockchip-thermal.txt | 41 ++++++++++++++++++++++
>>> 1 file changed, 41 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>>> new file mode 100644
>>> index 0000000..6fc8bc3
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>>> @@ -0,0 +1,41 @@
>>> +* Temperature Sensor ADC (TSADC) on rockchip SoCs
>>> +
>>> +Required properties:
>>> +- compatible: "rockchip,rk3288-tsadc"
>>> +- reg: physical base address of the controller and length of memory mapped
>>> + region.
>>> +- interrupts: The interrupt number to the cpu. The interrupt specifier format
>>> + depends on the interrupt controller.
>>> +- clocks: Must contain an entry for each entry in clock-names.
>>> +- clock-names: Shall be "tsadc" for the converter-clock, and "apb_pclk" for
>>> + the peripheral clock.
>>> +- num-trips: number of total trip points, this is required, set it 0 if none,
>>> + if greater than 0, the following properties must be defined;
>> nit: there is whitespace damage (space before tab) on the line before
>> this one. It's more obvious in the patch you uploaded to gerrit which
>> highlights this in red:
>>
>> https://chromium-review.googlesource.com/#/c/213967/5/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>>
>> Did you run your patches through checkpatch before submitting?
> FWIW vim users like me can put the following in their .vimrc file to
> have whitespace damage visible right away:
>
> :highlight RedundantSpaces ctermbg=red guibg=red
> :match RedundantSpaces /\s\+$\| \+\ze\t/
>
> Thanks.
It's a very useful, Thank you for sharing.
--
Best regards,
Caesar
next prev parent reply other threads:[~2014-09-18 2:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 3:59 [PATCH v5 0/4] Rockchip soc thermal driver Caesar Wang
2014-09-17 3:59 ` [PATCH v5 1/4] thermal: rockchip: add driver for Thermal Caesar Wang
2014-09-17 17:02 ` Dmitry Torokhov
2014-09-18 8:31 ` Caesar Wang
2014-09-18 17:02 ` Dmitry Torokhov
2014-09-17 3:59 ` [PATCH v5 2/4] dt-bindings: document Rockchip thermal Caesar Wang
2014-09-17 19:48 ` Doug Anderson
2014-09-17 20:13 ` Dmitry Torokhov
2014-09-18 2:33 ` Caesar Wang [this message]
2014-09-18 9:27 ` Tomeu Vizoso
2014-09-18 13:25 ` Caesar Wang
2014-09-18 14:19 ` Tomeu Vizoso
2014-09-18 17:18 ` Dmitry Torokhov
2014-09-17 3:59 ` [PATCH v5 3/4] ARM: dts: add main Thermal info to rk3288 Caesar Wang
2014-09-17 3:59 ` [PATCH v5 4/4] ARM: dts: enable Thermal on rk3288-evb board Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541A4461.4080101@rock-chips.com \
--to=caesar.wang@rock-chips$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox