From: linux@roeck-us•net (Guenter Roeck)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/4] ARM: meson: add watchdog driver
Date: Sat, 20 Sep 2014 09:29:23 -0700 [thread overview]
Message-ID: <541DAB63.4010108@roeck-us.net> (raw)
In-Reply-To: <CAOQ7t2a09zB2=qyDfsnJN94Wrj9Zu1c33R1bG5NC2QwzndtmcA@mail.gmail.com>
On 09/20/2014 09:15 AM, Carlo Caione wrote:
> On Sat, Sep 20, 2014 at 5:30 PM, Guenter Roeck <linux@roeck-us•net> wrote:
>> On 09/19/2014 01:36 PM, Carlo Caione wrote:
>>>
>>> This patch adds the watchdog driver for the Amlogic Meson SoCs used also
>>> to reboot the device.
>>>
>>> Signed-off-by: Carlo Caione <carlo@caione•org>
>>> ---
>>
>> [ ... ]
>>>
>>> +module_param(nowayout, bool, 0);
>>> +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started "
>>> + "(default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
>>> +
>>
>>
>> Checkpatch says:
>>
>> WARNING: quoted string split across lines
>> #295: FILE: drivers/watchdog/meson_wdt.c:231:
>> +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started "
>> + "(default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
>
> Thought that it was "somehow tolerated" :)
Not me, at least not in this case.
> But since I'm wrong I'll submit a v4.
>
MODULE_PARAM_DESC(nowayout,
"Watchdog cannot be stopped once started (default="
__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
is a really simple way of ensuring that you meet both the 80-column limit
and avoid the warning. The idea should not be to try to get away with
as many checkpatch warnings as possible ;-).
Guenter
next prev parent reply other threads:[~2014-09-20 16:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 20:36 [PATCH v3 0/4] ARM: meson: watchdog driver Carlo Caione
2014-09-19 20:36 ` [PATCH v3 1/4] ARM: docs: add documentation binding for meson watchdog Carlo Caione
2014-09-20 15:28 ` Guenter Roeck
2014-09-20 16:08 ` Carlo Caione
2014-09-20 16:10 ` Guenter Roeck
2014-09-19 20:36 ` [PATCH v3 2/4] ARM: meson: add watchdog driver Carlo Caione
2014-09-20 15:30 ` Guenter Roeck
2014-09-20 16:15 ` Carlo Caione
2014-09-20 16:29 ` Guenter Roeck [this message]
2014-09-19 20:36 ` [PATCH v3 3/4] ARM: DTS: meson: update DTSI to add watchdog node Carlo Caione
2014-09-19 20:36 ` [PATCH v3 4/4] ARM: defconfig: update multi_v7_defconfig Carlo Caione
2014-09-20 2:50 ` [PATCH v3 0/4] ARM: meson: watchdog driver Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541DAB63.4010108@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox