From: sudeep.holla@arm•com (Sudeep Holla)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] clocksource: arm_arch_timer: discard unavailable timers correctly
Date: Wed, 24 Sep 2014 16:55:32 +0100 [thread overview]
Message-ID: <5422E974.3090506@arm.com> (raw)
In-Reply-To: <20140924154802.GK5729@leverpostej>
On 24/09/14 16:48, Mark Rutland wrote:
> On Wed, Sep 24, 2014 at 04:16:47PM +0100, Sudeep Holla wrote:
>> Hi Mark,
>>
>> On 17/09/14 20:39, Sudeep Holla wrote:
>>> Currently we wait until both cp15 and mem timers are probed if we
>>> have both timer device nodes present in the device tree without
>>> checking if the device is actually available. If one of the timer
>>> device node present is disabled, the system locks up on the boot
>>> as no timer gets registered.
>>>
>>> This patch adds the check for the availablity of the timer device
>>> so that we unavailable timers are discarded correctly. It also adds
>>> the missing of_node_put.
>>>
>>> Cc: Stephen Boyd <sboyd@codeaurora•org>
>>> Cc: Mark Rutland <mark.rutland@arm•com>
>>
>> If your are fine with this, can I ask Daniel you pick this up ?
>
> While I'd prefer to see the cp15 and mmio timer driver pulled apart,
> that's not going to happen at any point soon. For the moment, this is
Agreed :)
> far better than the current state of affairs. So:
>
> Acked-by: Mark Rutland <mark.rutland@arm•com>
>
Thanks
Regards,
Sudeep
next prev parent reply other threads:[~2014-09-24 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 23:50 [PATCH] clocksource: arm_arch_timer: discard unavailable timers correctly Sudeep Holla
2014-09-17 0:01 ` Stephen Boyd
2014-09-17 19:39 ` [PATCH v2] " Sudeep Holla
2014-09-17 19:51 ` Stephen Boyd
2014-09-24 15:16 ` Sudeep Holla
2014-09-24 15:48 ` Mark Rutland
2014-09-24 15:55 ` Sudeep Holla [this message]
2014-09-24 16:23 ` [PATCH v3] " Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5422E974.3090506@arm.com \
--to=sudeep.holla@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox