public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [RESEND PATCH] ARM: at91/PMC: don't forget to write PMC_PCDR register to disable clocks
Date: Wed, 24 Sep 2014 18:03:03 +0200	[thread overview]
Message-ID: <5422EB37.2060402@atmel.com> (raw)
In-Reply-To: <1411393893-12291-1-git-send-email-ludovic.desroches@atmel.com>

On 22/09/2014 15:51, Ludovic Desroches :
> When introducing support for sama5d3, the write to PMC_PCDR register has
> been accidentally removed.
> 
> Reported-by: Nathalie Cyrille <nathalie.cyrille@atmel•com>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel•com>
> Cc: <stable@vger•kernel.org> # 3.10.x and later

Absolutely: thanks for the fix!

Acked-by: Nicolas Ferre <nicolas.ferre@atmel•com>

I queue it in at91-3.18-fixes-non-critical branch and it may show-up in
3.18 or 3.19.

Best regards,


> ---
> 
> Sorry for the noise, typo in the cc list!
> 
> Ludovic
> 
>  arch/arm/mach-at91/clock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-at91/clock.c b/arch/arm/mach-at91/clock.c
> index 034529d..d66f102 100644
> --- a/arch/arm/mach-at91/clock.c
> +++ b/arch/arm/mach-at91/clock.c
> @@ -962,6 +962,7 @@ static int __init at91_clock_reset(void)
>  	}
>  
>  	at91_pmc_write(AT91_PMC_SCDR, scdr);
> +	at91_pmc_write(AT91_PMC_PCDR, pcdr);
>  	if (cpu_is_sama5d3())
>  		at91_pmc_write(AT91_PMC_PCDR1, pcdr1);
>  
> 


-- 
Nicolas Ferre

      reply	other threads:[~2014-09-24 16:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 13:51 [RESEND PATCH] ARM: at91/PMC: don't forget to write PMC_PCDR register to disable clocks Ludovic Desroches
2014-09-24 16:03 ` Nicolas Ferre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5422EB37.2060402@atmel.com \
    --to=nicolas.ferre@atmel$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox