public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: bhuvanchandra.dv@toradex•com (BhuvanChandra.DV)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/2] ARM: dts: vf610-colibri: Add PWM support
Date: Sun, 28 Sep 2014 09:38:43 -0700	[thread overview]
Message-ID: <54283993.5070906@toradex.com> (raw)
In-Reply-To: <20140926022232.GI21077@dragon>


On 9/25/2014 7:22 PM, Shawn Guo wrote:

> On Mon, Sep 22, 2014 at 03:38:11PM +0530, Bhuvanchandra DV wrote:
>> The Colibri standard defines four pins as PWM outputs, two of them (PWM
>> A and C) are routed to FTM instance 0 and the other two (PWM B and D)
>> are routed to FTM instance 1. Hence enable both FTM instances for the
>> Colibri module and mux the four pins accordingly.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex•com>
> You should add Stefan's ACK tag.

Ok

>> ---
>>   arch/arm/boot/dts/vf610-colibri-eval-v3.dts |    8 ++++++++
>>   arch/arm/boot/dts/vf610-colibri.dtsi        |   24 ++++++++++++++++++++++++
>>   2 files changed, 32 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> index 7fb3066..00f63d9 100644
>> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
>> @@ -33,6 +33,14 @@
>>   	status = "okay";
>>   };
>>   
>> +&pwm0 {
>> +	status = "okay";
>> +};
>> +
>> +&pwm1 {
>> +	status = "okay";
>> +};
>> +
> I was trying to apply the patches, but found pwm1 is not available in
> vf610.dtsi at all.  What tree is your patch generated against?  Or did I
> miss any prerequisite patches?
>
> Shawn

One prerequisite patch(PATCH 1/3) was missed. Available over here:
https://lkml.org/lkml/2014/9/17/86


>>   &uart0 {
>>   	status = "okay";
>>   };
>> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
>> index 0cd8343..1f73c1c 100644
>> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
>> @@ -44,6 +44,16 @@
>>   	arm,tag-latency = <3 2 3>;
>>   };
>>   
>> +&pwm0 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_pwm0>;
>> +};
>> +
>> +&pwm1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_pwm1>;
>> +};
>> +
>>   &uart0 {
>>   	pinctrl-names = "default";
>>   	pinctrl-0 = <&pinctrl_uart0>;
>> @@ -97,6 +107,20 @@
>>   			>;
>>   		};
>>   
>> +		pinctrl_pwm0: pwm0grp {
>> +			fsl,pins = <
>> +				VF610_PAD_PTB0__FTM0_CH0		0x1182
>> +				VF610_PAD_PTB1__FTM0_CH1		0x1182
>> +			>;
>> +		};
>> +
>> +		pinctrl_pwm1: pwm1grp {
>> +			fsl,pins = <
>> +				VF610_PAD_PTB8__FTM1_CH0		0x1182
>> +				VF610_PAD_PTB9__FTM1_CH1		0x1182
>> +			>;
>> +		};
>> +
>>   		pinctrl_uart0: uart0grp {
>>   			fsl,pins = <
>>   				VF610_PAD_PTB10__UART0_TX		0x21a2
>> -- 
>> 1.7.9.5
>>

  reply	other threads:[~2014-09-28 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 10:08 [PATCH v3 0/2] Add PWM and backlight support for Colibri VF61 modules Bhuvanchandra DV
2014-09-22 10:08 ` [PATCH v3 1/2] ARM: dts: vf610-colibri: Add PWM support Bhuvanchandra DV
2014-09-26  2:22   ` Shawn Guo
2014-09-28 16:38     ` BhuvanChandra.DV [this message]
2014-09-28  1:24       ` Shawn Guo
2014-09-29 16:45         ` BhuvanChandra.DV
2014-09-22 10:08 ` [PATCH v3 2/2] ARM: dts: vf610-colibri: Add backlight support Bhuvanchandra DV

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54283993.5070906@toradex.com \
    --to=bhuvanchandra.dv@toradex$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox