Subject: [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

From: [email-masked] (nick)
Date: Sun, 28 Sep 2014 16:45:37 -0400

On 14-09-28 12:23 PM, Sudip Mukherjee wrote:
> On Sat, Sep 27, 2014 at 10:50:52PM -0400, Nicholas Krause wrote:
>> This removes the FIXME message and issue with reading in this driver before resuming
>> in the function, sa1111_resume.
>>
>> Signed-off-by: Nicholas Krause <[email-masked]>
>> ---
>>  arch/arm/common/sa1111.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
>> index e57d7e5..0c4b9a9 100644
>> --- a/arch/arm/common/sa1111.c
>> +++ b/arch/arm/common/sa1111.c
>> @@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
>>  
>>  	/*
>>  	 * Ensure that the SA1111 is still here.
>> -	 * FIXME: shouldn't do this here.
>>  	 */
>> -	id = sa1111_readl(sachip->base + SA1111_SKID);
> 
> do you understand the effect of removing this???
> what is the value of id in the next part of the code?
> 
> thanks
> sudip
>>  	if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
>>  		__sa1111_remove(sachip);
>>  		platform_set_drvdata(dev, NULL);
>> -- 
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
We will set the driver data to NULL and therefore may cause a bug due to NULL data.
Nick