From: kiran.padwal@smartplayin•com (Kiran Padwal)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC 4/7] soc: qcom: Add Shared Memory Manager driver
Date: Tue, 30 Sep 2014 11:58:16 +0530 [thread overview]
Message-ID: <542A4D80.60101@smartplayin.com> (raw)
In-Reply-To: <542A4AEF.2030402@smartplayin.com>
Hi,
On Tuesday 30 September 2014 11:47 AM, Kiran Padwal wrote:
> Hi Bjorn,
>
> On Tuesday 30 September 2014 06:04 AM, Bjorn Andersson wrote:
>> The Shared Memory Manager driver implements an interface for allocating
>> and accessing items in the memory area shared among all of the
>> processors in a Qualcomm platform.
>>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile•com>
>> ---
>
> <snip>
>
>> +
>> +static int qcom_smem_probe(struct platform_device *pdev)
>> +{
>> + struct qcom_smem *smem;
>> + struct resource *res;
>> + size_t array_size;
>> + int num_regions = 0;
>> + int i;
>> +
>> + for (i = 0; i < pdev->num_resources; i++) {
>> + res = &pdev->resource[i];
>> +
>> + if (resource_type(res) == IORESOURCE_MEM)
>> + num_regions++;
>> + }
>> +
>> + if (num_regions == 0) {
>> + dev_err(&pdev->dev, "no smem regions specified\n");
>> + return -EINVAL;
>> + }
>> +
>> + array_size = num_regions * sizeof(struct smem_region);
>> + smem = devm_kzalloc(&pdev->dev, sizeof(*smem) + array_size, GFP_KERNEL);
>> + if (!smem)
>> + return -ENOMEM;
>> +
>> + smem->dev = &pdev->dev;
>> + smem->hwlock = of_hwspin_lock_request(pdev->dev.of_node, NULL);
>
> Compilation breaks while I try to compile with this patch.
> Do I missing anything? Below is the error I am getting,
>
> drivers/soc/qcom/qcom_smem.c: In function ?qcom_smem_probe?:
> drivers/soc/qcom/qcom_smem.c:274:2: error: implicit declaration of function ?of_hwspin_lock_request? [-Werror=implicit-function-declaration]
> smem->hwlock = of_hwspin_lock_request(pdev->dev.of_node, NULL)
I am sorry I missed the note in commit message of this patch. I did look for any such note in cover letter
and also googled around for any change to find this function.
Could not find and hence posted comment. Please ignore.
>
> Thanks,
> --Kiran
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-09-30 6:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 0:34 [RFC 0/7] Qualcomm SMEM, SMD, RPM and regulators Bjorn Andersson
2014-09-30 0:34 ` [RFC 1/7] soc: qcom: Add device tree binding for SMEM Bjorn Andersson
2014-09-30 13:52 ` Kumar Gala
2014-09-30 19:03 ` Stephen Boyd
2014-09-30 20:00 ` Bjorn Andersson
2014-09-30 21:55 ` Suman Anna
2014-09-30 0:34 ` [RFC 2/7] soc: qcom: Add device tree binding for SMD Bjorn Andersson
2014-09-30 0:34 ` [RFC 3/7] mfd: devicetree: bindings: Add Qualcomm SMD based RPM DT binding Bjorn Andersson
2014-09-30 13:46 ` Kumar Gala
2014-09-30 14:37 ` Bjorn Andersson
2014-09-30 23:16 ` Jeffrey Hugo
2014-10-01 0:08 ` Bjorn Andersson
2014-10-08 21:47 ` Jeffrey Hugo
2014-10-24 15:59 ` Bjorn Andersson
2014-09-30 0:34 ` [RFC 4/7] soc: qcom: Add Shared Memory Manager driver Bjorn Andersson
2014-09-30 6:17 ` Kiran Padwal
2014-09-30 6:28 ` Kiran Padwal [this message]
2014-09-30 14:15 ` Bjorn Andersson
2014-10-08 21:33 ` Jeffrey Hugo
2014-10-17 14:51 ` Bjorn Andersson
2014-10-26 15:04 ` Andreas Färber
2014-10-28 0:34 ` Bjorn Andersson
2014-09-30 0:34 ` [RFC 5/7] soc: qcom: Add Shared Memory Driver Bjorn Andersson
2014-10-02 22:38 ` Stephen Boyd
2014-10-04 0:02 ` Bjorn Andersson
2014-10-29 14:28 ` Ohad Ben-Cohen
2014-10-30 0:38 ` Bjorn Andersson
2014-10-30 13:34 ` Ohad Ben-Cohen
2014-10-30 15:04 ` Bjorn Andersson
2014-09-30 0:34 ` [RFC 6/7] mfd: qcom-smd-rpm: Driver for the Qualcomm RPM over SMD Bjorn Andersson
2014-10-08 8:40 ` Lee Jones
2014-10-17 13:55 ` Bjorn Andersson
2014-10-20 7:22 ` Lee Jones
2014-10-24 16:45 ` Bjorn Andersson
2014-09-30 0:34 ` [RFC 7/7] regulator: qcom-smd-rpm: Regulator driver for the Qualcomm RPM Bjorn Andersson
2014-10-01 18:13 ` Mark Brown
2014-09-30 13:49 ` [RFC 0/7] Qualcomm SMEM, SMD, RPM and regulators Kumar Gala
2014-09-30 14:51 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542A4D80.60101@smartplayin.com \
--to=kiran.padwal@smartplayin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox