From: j.uzycki@elproma•com.pl (Janusz Użycki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] serial: mxs-auart: add sysrq support
Date: Mon, 06 Oct 2014 13:34:25 +0200 [thread overview]
Message-ID: <54327E41.9070607@elproma.com.pl> (raw)
In-Reply-To: <CAOMZO5Cctk4UNvK2=MC9tf2Fzi1r0+qdn-SXfC-=W9n3T=a+VA@mail.gmail.com>
Hi,
W dniu 2014-10-04 18:19, Fabio Estevam pisze:
> Janusz,
>
> On Mon, Sep 29, 2014 at 11:11 AM, Janusz Uzycki <j.uzycki@elproma•com.pl> wrote:
>>> So I'm deleting all of these now, please resend the latest
>>> versions you have, with properly versioning
>>> and order information.
>> Sure. If you don't want to comment dirty patches
>> I will not send you them.
>> I can send you only the final version, commented before.
>>
>> On the moment this patch is ready to apply.
>>
>> [PATCH RESEND] serial: mxs-auart: add sysrq support
>> The patch is resent to apply.
> What Greg is asking you to do is to provide a proper version
> annotation in your patches.
>
> For example: [PATCH v2] serial: mxs-auart: add ...
>
> Then if you need to submit it again you should do:
>
> [PATCH v3] serial: mxs-auart: add ...
I will resend the rest of patches (as v4) this week.
This simple patch is independent from the previous patchset so
I decided to resubmit it alone ([PATCH RESEND] header used)
to apply.
I rather shouldn't resend the patch again I guess.
I sent the same initial version of the patch twice
after Greg's email so I did mess enough I think.
> Also, always explain below the --- line what changed from one version to another
I thought composing cover letter is the only solution for resent patch
or series.
As I understood this way is appropriate for single patch only (not patch
set).
"Below" - it means between the line and diffstat?
Should I add new/second '---' line before diffstat?
best regards
Janusz
next prev parent reply other threads:[~2014-10-06 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:08 [PATCH] serial: mxs-auart: add sysrq support Janusz Uzycki
2014-09-26 14:08 ` Janusz Uzycki
2014-09-29 1:41 ` Greg Kroah-Hartman
2014-09-29 14:11 ` Janusz Uzycki
2014-10-04 16:19 ` Fabio Estevam
2014-10-06 11:34 ` Janusz Użycki [this message]
2014-10-06 11:38 ` Fabio Estevam
2014-10-02 18:11 ` [PATCH RESEND] " Janusz Uzycki
2014-10-02 18:11 ` Janusz Uzycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54327E41.9070607@elproma.com.pl \
--to=j.uzycki@elproma$(echo .)com.pl \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox