From: kishon@ti•com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 6/8] phy: miphy28lp: Add SSC support for PCIE
Date: Tue, 21 Oct 2014 17:19:01 +0530 [thread overview]
Message-ID: <5446482D.2060909@ti.com> (raw)
In-Reply-To: <CAG374jBJcX00S4nSugWXaUxAQV3Bwp+OxY0c2GJ-+rskzDzpGw@mail.gmail.com>
Hi,
On Monday 13 October 2014 01:46 PM, Gabriel Fernandez wrote:
> Hi Valdis,
> Thanks for your remark.
>
> Concerning multiple writing in MIPHY_PLL_SBR_1, the writing of the
> first 0 it's to be sure there is no previous request.
> Then we take account new setting by writing 0x02.
> And then we make it 0 to make sure there is no other pending requests.
>
> I added comments and macro to be more clear (see the code below).
>
>
> Hi Kishon,
>
> Do you want a new patch set (v4), or i wait other remarks from you ?
Apart from my comment below and for adding a common dt header file, rest of it
looks fine.
>
>
> for (val = 0; val < 2; val++) {
What is "2" here? Lets add a macro for it.
Thanks
Kishon
next prev parent reply other threads:[~2014-10-21 11:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 8:54 [PATCH v3 0/8] phy: miphy28lp: Introduce support for MiPHY28lp Gabriel FERNANDEZ
2014-09-26 8:54 ` [PATCH v3 1/8] phy: miphy28lp: Add Device Tree bindings for the MiPHY28lp Gabriel FERNANDEZ
2014-09-26 8:54 ` [PATCH v3 2/8] phy: miphy28lp: Add MiPHY28lp header file for DT x Driver defines Gabriel FERNANDEZ
2014-10-21 10:38 ` Kishon Vijay Abraham I
2014-10-21 15:49 ` Gabriel Fernandez
2014-10-22 5:20 ` Kishon Vijay Abraham I
2014-09-26 8:54 ` [PATCH v3 3/8] phy: miphy28lp: Provide support for the MiPHY28lp Generic PHY Gabriel FERNANDEZ
2014-09-26 8:54 ` [PATCH v3 4/8] ARM: DT: STi: STiH407: Add DT node for MiPHY28lp Gabriel FERNANDEZ
2014-09-26 8:54 ` [PATCH v3 5/8] phy: miphy28lp: Add SSC support for SATA Gabriel FERNANDEZ
2014-09-26 8:54 ` [PATCH v3 6/8] phy: miphy28lp: Add SSC support for PCIE Gabriel FERNANDEZ
2014-09-29 19:19 ` Valdis.Kletnieks at vt.edu
2014-10-13 8:16 ` Gabriel Fernandez
2014-10-13 16:12 ` Valdis.Kletnieks at vt.edu
2014-10-21 11:49 ` Kishon Vijay Abraham I [this message]
2014-10-21 15:51 ` Gabriel Fernandez
2014-09-26 8:54 ` [PATCH v3 7/8] phy: miphy28lp: Tune tx impedance across Soc cuts Gabriel FERNANDEZ
2014-09-26 8:54 ` [PATCH v3 8/8] ARM: multi_v7_defconfig: Enable MiPHY28lp - ST's Generic (SATA, PCIe & USB3) PHY Gabriel FERNANDEZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5446482D.2060909@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox