From: m.smarduch@samsung•com (Mario Smarduch)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v12 2/6] KVM: Add generic support for dirty page logging
Date: Thu, 30 Oct 2014 12:19:00 -0700 [thread overview]
Message-ID: <54528F24.6060602@samsung.com> (raw)
In-Reply-To: <20141030131430.5b50a7c0.cornelia.huck@de.ibm.com>
On 10/30/2014 05:14 AM, Cornelia Huck wrote:
> On Wed, 22 Oct 2014 15:34:07 -0700
> Mario Smarduch <m.smarduch@samsung•com> wrote:
>
>> This patch defines KVM_GENERIC_DIRTYLOG, and moves dirty log read function
>> to it's own file virt/kvm/dirtylog.c. x86 is updated to use the generic
>> dirty log interface, selecting KVM_GENERIC_DIRTYLOG in its Kconfig and
>> makefile. No other architectures are affected, each uses it's own version.
>> This changed from previous patch revision where non-generic architectures
>> were modified.
>>
>> In subsequent patch armv7 does samething. All other architectures continue
>> use architecture defined version.
>>
>
> Hm.
>
> "The x86 specific version of dirty page logging is generic enough to be
> used by other architectures, noteably ARMv7. So let's move the x86 code
> under virt/kvm/ and make it depend on KVM_GENERIC_DIRTYLOG. Other
> architectures continue to use their own implementations."
>
> ?
I'll update descriptions for both patches, with the more concise
descriptions.
Thanks.
>
>>
>> Signed-off-by: Mario Smarduch <m.smarduch@samsung•com>
>> ---
>> arch/x86/include/asm/kvm_host.h | 3 --
>> arch/x86/kvm/Kconfig | 1 +
>> arch/x86/kvm/Makefile | 1 +
>> arch/x86/kvm/x86.c | 86 ------------------------------
>> include/linux/kvm_host.h | 4 ++
>> virt/kvm/Kconfig | 3 ++
>> virt/kvm/dirtylog.c | 112 +++++++++++++++++++++++++++++++++++++++
>> 7 files changed, 121 insertions(+), 89 deletions(-)
>> create mode 100644 virt/kvm/dirtylog.c
>>
>
>> diff --git a/virt/kvm/dirtylog.c b/virt/kvm/dirtylog.c
>> new file mode 100644
>> index 0000000..67ffffa
>> --- /dev/null
>> +++ b/virt/kvm/dirtylog.c
>> @@ -0,0 +1,112 @@
>> +/*
>> + * kvm generic dirty logging support, used by architectures that share
>> + * comman dirty page logging implementation.
>
> s/comman/common/
>
> The approach looks sane to me, especially as it does not change other
> architectures needlessly.
>
next prev parent reply other threads:[~2014-10-30 19:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 22:34 [PATCH v12 0/6] arm/KVM: dirty page logging support for ARMv7 (3.17.0-rc1) Mario Smarduch
2014-10-22 22:34 ` [PATCH v12 1/6] KVM: Add architecture-defined TLB flush support Mario Smarduch
2014-10-30 12:06 ` Cornelia Huck
2014-11-05 16:10 ` Paolo Bonzini
2014-10-22 22:34 ` [PATCH v12 2/6] KVM: Add generic support for dirty page logging Mario Smarduch
2014-10-30 12:14 ` Cornelia Huck
2014-10-30 19:19 ` Mario Smarduch [this message]
2014-11-03 3:01 ` Takuya Yoshikawa
2014-11-03 19:34 ` Mario Smarduch
2014-11-01 10:12 ` James Hogan
2014-11-03 18:44 ` Mario Smarduch
2014-11-05 16:09 ` Paolo Bonzini
2014-11-05 23:05 ` Mario Smarduch
2014-11-06 10:14 ` Paolo Bonzini
2014-11-06 18:07 ` Mario Smarduch
2014-10-22 22:34 ` [PATCH v12 3/6] arm: KVM: Add ARMv7 API to flush TLBs Mario Smarduch
2014-10-22 22:34 ` [PATCH v12 4/6] arm: KVM: Add initial dirty page locking infrastructure Mario Smarduch
2014-10-27 23:26 ` [PATCH v12 0/6] arm/KVM: dirty page logging support for ARMv7 (3.17.0-rc1) Wanpeng Li
2014-10-28 0:28 ` Mario Smarduch
2014-10-28 1:24 ` Wanpeng Li
2014-10-28 16:15 ` Mario Smarduch
2014-10-28 16:29 ` [PATCH v12 0/6] 2nd-request for review comments: " Mario Smarduch
2014-10-30 12:11 ` [PATCH v12 0/6] " Christian Borntraeger
2014-10-30 19:27 ` Mario Smarduch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54528F24.6060602@samsung.com \
--to=m.smarduch@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox