From: knaack.h@gmx•de (Hartmut Knaack)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc
Date: Fri, 31 Oct 2014 22:09:34 +0100 [thread overview]
Message-ID: <5453FA8E.3080204@gmx.de> (raw)
In-Reply-To: <1414408111-2631-4-git-send-email-vigneshr@ti.com>
Vignesh R schrieb am 27.10.2014 12:08:
> The charge delay value is by default 0xB000. But it can be set to lower
> values on some boards as long as false pen-ups are avoided. Lowering the
> value increases the sampling rate (though current sampling rate is
> sufficient for tsc operation). Hence charge delay has been made a DT
> parameter.
>
I would recommend to use a few colons to separate some thoughts. Also, limit to 80 chars per line would be beneficial. See inline.
> Signed-off-by: Vignesh R <vigneshr@ti•com>
> ---
> .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 13 +++++++++++++
> arch/arm/boot/dts/am335x-evm.dts | 1 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> index 878549ba814d..ac62769e70e4 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
> @@ -28,6 +28,18 @@ Required properties:
> ti,adc-channels: List of analog inputs available for ADC.
> AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
>
> +Optional properties:
> +- child "tsc"
> + ti,charge-delay: Length of touch screen charge delay step in terms of
> + ADC clock cycles. Charge delay value should be large in order
> + to avoid false pen-up events. This value affects the overall
> + sampling speed hence need to be kept as low as possible while
<...> speed, hence needs to be <...>
> + avoiding false pen-up event. Start from a lower value say 0x400
<...> pen-up events. Start from a lower value, like 0x400, and increase <...>
> + and increase value until false pen-up events are avoided. The
> + pen-up detection happens immediately after the charge step
<...> charge step, so this <...>
> + so this does in fact function as a hardware knob for adjusting
> + the amount of "settling time".
> +
> Example:
> tscadc: tscadc at 44e0d000 {
> compatible = "ti,am3359-tscadc";
> @@ -36,6 +48,7 @@ Example:
> ti,x-plate-resistance = <200>;
> ti,coordiante-readouts = <5>;
> ti,wire-config = <0x00 0x11 0x22 0x33>;
> + ti,charge-delay = <0xB000>;
> };
>
> adc {
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index e2156a583de7..80be0462298b 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -641,6 +641,7 @@
> ti,x-plate-resistance = <200>;
> ti,coordinate-readouts = <5>;
> ti,wire-config = <0x00 0x11 0x22 0x33>;
> + ti,charge-delay = <0xB000>;
> };
>
> adc {
>
next prev parent reply other threads:[~2014-10-31 21:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 11:08 [PATCH 0/4] Touchscreen performance related fixes Vignesh R
2014-10-27 11:08 ` [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2014-10-31 21:03 ` Hartmut Knaack
2014-11-07 5:48 ` Vignesh R
2014-11-06 14:19 ` Richard Cochran
2014-11-07 5:34 ` Vignesh R
2014-11-07 8:00 ` Richard Cochran
2014-11-10 10:46 ` Vignesh R
2014-11-07 10:17 ` Richard Cochran
2014-10-27 11:08 ` [PATCH 2/4] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2014-11-03 15:05 ` Lee Jones
2014-11-07 5:48 ` Vignesh R
2014-10-27 11:08 ` [PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc Vignesh R
2014-10-31 21:09 ` Hartmut Knaack [this message]
2014-11-07 5:48 ` Vignesh R
2014-10-27 11:08 ` [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-10-27 17:34 ` [PATCH 0/4] Touchscreen performance related fixes Sebastian Andrzej Siewior
2014-10-27 19:02 ` Griffis, Brad
2014-11-03 12:17 ` Sebastian Andrzej Siewior
2014-11-04 11:44 ` Vignesh R
2014-11-04 12:37 ` Sebastian Andrzej Siewior
2014-11-05 12:08 ` Vignesh R
2014-11-17 12:18 ` Vignesh R
2014-11-03 18:09 ` Richard Cochran
2014-11-06 7:42 ` Vignesh R
2014-11-12 13:00 ` Johannes Pointner
2014-11-13 12:23 ` Vignesh R
2014-11-17 11:39 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5453FA8E.3080204@gmx.de \
--to=knaack.h@gmx$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox