From: d-gerlach@ti•com (Dave Gerlach)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v9] ARM: omap: edma: add suspend resume hook
Date: Wed, 5 Nov 2014 12:10:55 -0600 [thread overview]
Message-ID: <545A682F.4060306@ti.com> (raw)
In-Reply-To: <545A4A99.70407@ti.com>
Sekhar,
On 11/05/2014 10:04 AM, Sekhar Nori wrote:
> On Wednesday 05 November 2014 09:27 PM, Dave Gerlach wrote:
>> On 08/26/2014 03:52 AM, Daniel Mack wrote:
>>> This patch makes the edma driver resume correctly after suspend. Tested
>>> on an AM33xx platform with cyclic audio streams and omap_hsmmc.
>>>
>>> All information can be reconstructed by already known runtime
>>> information.
>>>
>>> As we now use some functions that were previously only used from __init
>>> context, annotations had to be dropped.
>>>
>>> [nm at ti.com: added error handling for runtime + suspend_late/early_resume]
>>> Signed-off-by: Nishanth Menon <nm@ti•com>
>>> Signed-off-by: Daniel Mack <zonque@gmail•com>
>>> Tested-by: Joel Fernandes <joelf@ti•com>
>>> Acked-by: Joel Fernandes <joelf@ti•com>
>>> ---
>>> Changes from v8:
>>>
>>> * Drop the edma_suspend hook altogether. Even though back then
>>> when I wrote the code I was sure disabling the interrupts
>>> during suspend is necessary, tests now show it in fact isn't.
>>> My test setup still works if that code is omitted.
>>> * Use SET_LATE_SYSTEM_SLEEP_PM_OPS in the dev_pm_ops
>>> declaration.
>>>
>>> Thanks to Sekhar for pointing out the above.
>>>
>>> arch/arm/common/edma.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++--
>>> 1 file changed, 58 insertions(+), 2 deletions(-)
>>
>> Doesn't seem to be any comments here, any chance this can be picked up? This
>> patch always seems to get missed but will be needed for suspend/resume on both
>> AM335x and AM437x.
>
> Dave, do you have a branch against mainline with suspend working on any
> of these SoCs using which I can test this patch?
Yes, here is WIP of next version with all required patches + this one.
https://github.com/dgerlach/linux-pm/tree/pm-ds0-v3.18-rc3-WIP
For suspend to work you need to select:
CONFIG_WKUP_M3_IPC=y
CONFIG_WKUP_M3_RPROC=y
And you need to enable USB for multiple suspends to work.
You can get am335x-pm-firmware.elf FW here from HEAD:
https://git.ti.com/ti-cm3-pm-firmware/amx3-cm3/commits/next
You can place in /lib/firmware and select CONFIG_FW_LOADER_USER_HELPER_FALLBACK
or build into kernel.
Also for what it's worth you can have my tested by:
Tested-by: Dave Gerlach <d-gerlach@ti•com>
I have tested on am335x-boneblack, am335x-evm, and am335x-evmsk, multiple
suspend cycles work with no issue.
Regards,
Dave
>
> Thanks,
> Sekhar
>
next prev parent reply other threads:[~2014-11-05 18:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 8:52 [PATCH v9] ARM: omap: edma: add suspend resume hook Daniel Mack
2014-11-05 15:57 ` Dave Gerlach
2014-11-05 16:04 ` Sekhar Nori
2014-11-05 18:10 ` Dave Gerlach [this message]
2014-11-06 8:33 ` Sekhar Nori
2014-11-06 14:36 ` Dave Gerlach
2014-11-14 17:03 ` Sekhar Nori
2014-11-14 17:07 ` Daniel Mack
2014-11-17 15:03 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A682F.4060306@ti.com \
--to=d-gerlach@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox