From: s.nawrocki@samsung•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [alsa-devel] [PATCH] ASoC: samsung: ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk()
Date: Thu, 20 Nov 2014 11:44:33 +0100 [thread overview]
Message-ID: <546DC611.8090806@samsung.com> (raw)
In-Reply-To: <1416477797-27332-1-git-send-email-padma.v@samsung.com>
On 20/11/14 11:03, Padmavathi Venna wrote:
> In the i2s_set_sysclk() callback we are currently clearing all bits
> of the IISMOD register in i2s_set_sysclk. It's due to an incorrect
> mask used for the AND operation which is introduced in commit
> a5a56871f804edac93a53b5e871c0e9818fb9033 (ASoC: samsung:
> add support for exynos7 I2S controller) and also adds the missing
The patch looks good to me, I'd just write about the missing break
in a separate sentence, i.e. s/and also adds/. Also add/
> break statement.
>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung•com>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung•com>
> Signed-off-by: Padmavathi Venna <padma.v@samsung•com>
> ---
> sound/soc/samsung/i2s.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
> index 0df6547..e1ace52 100644
> --- a/sound/soc/samsung/i2s.c
> +++ b/sound/soc/samsung/i2s.c
> @@ -494,7 +494,7 @@ static int i2s_set_sysclk(struct snd_soc_dai *dai,
> if (dir == SND_SOC_CLOCK_IN)
> mod |= 1 << i2s_regs->cdclkcon_off;
> else
> - mod &= 0 << i2s_regs->cdclkcon_off;
> + mod &= ~(1 << i2s_regs->cdclkcon_off);
>
> i2s->rfs = rfs;
> break;
> @@ -551,10 +551,11 @@ static int i2s_set_sysclk(struct snd_soc_dai *dai,
> }
>
> if (clk_id == 0)
> - mod &= 0 << i2s_regs->rclksrc_off;
> + mod &= ~(1 << i2s_regs->rclksrc_off);
> else
> mod |= 1 << i2s_regs->rclksrc_off;
>
> + break;
> default:
> dev_err(&i2s->pdev->dev, "We don't serve that!\n");
> return -EINVAL;
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-11-20 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 10:03 [PATCH] ASoC: samsung: ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk() Padmavathi Venna
2014-11-20 10:44 ` Sylwester Nawrocki [this message]
2014-11-21 18:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546DC611.8090806@samsung.com \
--to=s.nawrocki@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox