From: j.anaszewski@samsung•com (Jacek Anaszewski)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC] adp1653: Add device tree bindings for LED controller
Date: Thu, 20 Nov 2014 13:48:27 +0100 [thread overview]
Message-ID: <546DE31B.20602@samsung.com> (raw)
In-Reply-To: <20141120121202.GA27527@amd>
Hi Pavel,
On 11/20/2014 01:12 PM, Pavel Machek wrote:
> Hi!
>
>> I would also swap the segments of a property name to follow the convention
>> as in case of "regulator-max-microamp".
>>
>> Updated version:
>>
>> ==========================================================
>>
>> Optional properties for child nodes:
>> - max-microamp : maximum intensity in microamperes of the LED
>> (torch LED for flash devices)
>> - flash-max-microamp : maximum intensity in microamperes of the
>> flash LED; it is mandatory if the led should
>> support the flash mode
>> - flash-timeout-microsec : timeout in microseconds after which the flash
>> led is turned off
>
> Works for me. Do you want to submit a patch or should I do it?
You can submit a patch for leds/common.txt and a separate patch for the
adp1653 with a reference to the leds/common.txt for the child nodes.
>
>> - indicator-pattern : identifier of the blinking pattern for the
>> indicator led
>>
>
> This would need a bit more documentation, no?
- indicator-pattern : identifier of the blinking pattern for the
indicator led; valid identifiers should be
defined in the documentation of the parent
node.
I wouldn't go for pre-defined identifiers as the pattern
can be a combination of various settings like ramp-up, ramp-down,
pulse time etc. Drivers should expose only few combinations of
these settings in my opinion, like e.g. leds-lm355x.c does.
Regards,
Jacek
next prev parent reply other threads:[~2014-11-20 12:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 7:59 [RFC] adp1653: Add device tree bindings for LED controller Pavel Machek
2014-11-16 8:11 ` Lars-Peter Clausen
2014-11-16 8:43 ` Pavel Machek
2014-11-16 10:09 ` Andreas Färber
2014-11-16 10:15 ` Pavel Machek
2014-11-17 8:43 ` Pali Rohár
2014-11-17 10:05 ` Pavel Machek
2014-11-17 10:09 ` Pali Rohár
2014-11-17 10:15 ` Pavel Machek
2014-11-17 14:55 ` Tony Lindgren
2014-11-17 15:01 ` Pali Rohár
2014-11-17 15:04 ` Sakari Ailus
2014-11-17 15:15 ` Pali Rohár
2014-11-22 18:45 ` Ivaylo Dimitrov
2014-11-17 15:06 ` Tony Lindgren
2014-11-17 15:21 ` Pali Rohár
2014-11-18 18:35 ` Pavel Machek
2014-11-19 18:01 ` Sakari Ailus
2014-11-17 14:58 ` Sakari Ailus
2014-11-18 8:09 ` Jacek Anaszewski
2014-11-18 8:46 ` Pavel Machek
2014-11-18 10:04 ` Jacek Anaszewski
2014-11-18 11:32 ` Pavel Machek
2014-11-18 12:52 ` Jacek Anaszewski
2014-11-18 13:21 ` Pavel Machek
2014-11-18 16:02 ` Jacek Anaszewski
2014-11-18 16:51 ` Pavel Machek
2014-11-19 9:45 ` Jacek Anaszewski
2014-11-19 17:53 ` Sakari Ailus
2014-11-20 9:21 ` Jacek Anaszewski
2014-11-20 12:13 ` Pavel Machek
2014-11-20 12:12 ` Pavel Machek
2014-11-20 12:48 ` Jacek Anaszewski [this message]
2014-11-20 12:38 ` Jacek Anaszewski
2014-11-18 8:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546DE31B.20602@samsung.com \
--to=j.anaszewski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox