From: pankaj.dubey@samsung•com (Pankaj Dubey)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 1/2] clk: samsung: exynos5440: move restart code into clock driver
Date: Fri, 21 Nov 2014 16:00:14 +0530 [thread overview]
Message-ID: <546F1436.4020101@samsung.com> (raw)
In-Reply-To: <546E2968.1070800@samsung.com>
Hi Kukjin,
On Thursday 20 November 2014 11:18 PM, Sylwester Nawrocki wrote:
> On 19/11/14 04:37, Pankaj Dubey wrote:
>>>>
>>>>>> +static int exynos5440_clk_restart_notify(struct notifier_block *this,
>>>>>> + unsigned long code, void *unused)
>>>>>> +{
>>>>>> + u32 val, status;
>>>>>> +
>>>>>> + status = readl_relaxed(reg_base + 0xbc);
>>>>>> + val = readl_relaxed(reg_base + 0xcc);
>>>>>> + val = (val & 0xffff0000) | (status & 0xffff);
>>>>>> + writel_relaxed(val, reg_base + 0xcc);
>>>>
>>>> Can we have macro definitions for these 0xcc, 0xbc address offsets ?
>>>> I must say I couldn't find them documented in any Exynos datasheet I've
>> got though.
>>>>
>>
>> I also wished this, but I could not find them documented.
>> So I tried to keep logic of original code as it is, just changed location.
>> I would also like to mention that I have not tested this on exynos5440 as I
>> do not have
>> one with me. I believe if it was working at its original place in
>> exynos_restart it should work
>> here also. Other patch (2/2) I have verified on Exynos3250 board and its
>> working well.
>
> I think it's best to merge both patches in that series through
> the arm-soc tree, since applying them not in order may cause some
> breakage. Thus I'd let Kukjin take this patch set into his tree.
>
> For both patches:
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung•com>
>
Will you please take this series into your tree.
Thanks,
Pankaj Dubey
> --
> Thanks,
> Sylwester
>
next prev parent reply other threads:[~2014-11-21 10:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 10:47 [PATCH v5 0/2] Handle reboot for Exynos SoC via restart_handler Pankaj Dubey
2014-11-18 10:47 ` [PATCH v5 1/2] clk: samsung: exynos5440: move restart code into clock driver Pankaj Dubey
2014-11-18 15:17 ` Sylwester Nawrocki
2014-11-19 3:37 ` Pankaj Dubey
2014-11-20 17:48 ` Sylwester Nawrocki
2014-11-21 10:30 ` Pankaj Dubey [this message]
2014-11-22 2:08 ` Kukjin Kim
2014-11-24 2:16 ` amit daniel kachhap
2014-11-18 10:47 ` [PATCH v5 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver Pankaj Dubey
2014-11-18 15:19 ` Sylwester Nawrocki
2014-11-19 3:16 ` Pankaj Dubey
2014-11-19 14:26 ` Sylwester Nawrocki
2014-11-21 4:28 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546F1436.4020101@samsung.com \
--to=pankaj.dubey@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox