From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] Add support for SCCB devices into PXA27x I2C controller
Date: Sun, 23 Nov 2014 19:23:02 +0300 [thread overview]
Message-ID: <547209E6.9010905@cogentembedded.com> (raw)
In-Reply-To: <54711397.9060601@tul.cz>
Hello.
On 11/23/2014 1:52 AM, Petr Cvek wrote:
> Add support for SCCB devices into PXA27x I2C controller.
> Fix generated START but no STOP for message without I2C_M_NOSTART flag. Add
> support for I2C_M_IGNORE_NAK flag.
> Signed-off-by: Petr Cvek <petr.cvek@tul•cz>
> ---
> drivers/i2c/busses/i2c-pxa.c | 22 ++++++++++++++++------
> 1 file changed, 16 insertions(+), 6 deletions(-)
> diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
> index be671f7..adad044 100644
> --- a/drivers/i2c/busses/i2c-pxa.c
> +++ b/drivers/i2c/busses/i2c-pxa.c
> @@ -885,7 +885,14 @@ static void i2c_pxa_irq_txempty(struct pxa_i2c *i2c, u32
> isr)
> return; /* ignore */
> }
>
> - if (isr & ISR_BED) {
> + /*
Your patch has tabs replaces by spaces; probably your email agent's work. :-)
> + * Ignore NAK when flag I2C_M_IGNORE_NAK is present,
> + * this enables use of SCCB devices
> + */
> + if ((isr & ISR_BED) &&
> + (!((i2c->msg->flags & I2C_M_IGNORE_NAK) &&
> + (isr & ISR_ACKNAK)))) {
> +
This empty line is not needed.
[...]
WBR, Sergei
prev parent reply other threads:[~2014-11-23 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-22 22:52 [PATCH] Add support for SCCB devices into PXA27x I2C controller Petr Cvek
2014-11-23 8:31 ` Wolfram Sang
2014-11-23 22:21 ` [PATCH v2] " Petr Cvek
2014-11-24 17:27 ` Wolfram Sang
2014-11-25 5:05 ` [PATCH v3] i2c-pxa: add support for SCCB devices Petr Cvek
2014-11-25 14:26 ` Wolfram Sang
2014-11-23 16:23 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547209E6.9010905@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox