From: takahiro.akashi@linaro•org (AKASHI Takahiro)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v8 2/6] arm64: ptrace: allow tracer to skip a system call
Date: Tue, 25 Nov 2014 16:42:10 +0900 [thread overview]
Message-ID: <547432D2.7000909@linaro.org> (raw)
In-Reply-To: <20141120191738.GV19126@arm.com>
On 11/21/2014 04:17 AM, Will Deacon wrote:
> On Thu, Nov 20, 2014 at 05:13:04AM +0000, AKASHI Takahiro wrote:
>> On 11/20/2014 04:06 AM, Will Deacon wrote:
>>> On Wed, Nov 19, 2014 at 08:46:19AM +0000, AKASHI Takahiro wrote:
>>>> Syscall(-1) will return -ENOSYS whether or not a syscallno is explicitly
>>>> replaced with -1 by a tracer, and, in this sense, it is *skipped*.
>>>
>>> Ok, but now userspace sees -ENOSYS for a skipped system call in that case,
>>> whereas it would usually see whatever the trace put in x0, right?
>>
>> If you don't really like this behavior, how about this patch instead of my [2/6] patch?
>>
>> diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
>> index 726b910..1ef57d0 100644
>> --- a/arch/arm64/kernel/entry.S
>> +++ b/arch/arm64/kernel/entry.S
>> @@ -668,8 +668,15 @@ ENDPROC(el0_svc)
>> * switches, and waiting for our parent to respond.
>> */
>> __sys_trace:
>> + cmp w8, #-1 // default errno for invalid
>> + b.ne 1f // system call
>> + mov x0, #-ENOSYS
>> + str x0, [sp, #S_X0]
>> +1:
>> mov x0, sp
>> bl syscall_trace_enter
>> + cmp w0, #-1 // skip the syscall?
>> + b.eq __sys_trace_return_skipped
>> adr lr, __sys_trace_return // return address
>> uxtw scno, w0 // syscall number (possibly new)
>> mov x1, sp // pointer to regs
>> @@ -684,6 +691,7 @@ __sys_trace:
>>
>> __sys_trace_return:
>> str x0, [sp] // save returned x0
>> +__sys_trace_return_skipped:
>> mov x0, sp
>> bl syscall_trace_exit
>> b ret_to_user
>>
>> With this change, I believe, syscall(-1) returns -ENOSYS by default whether traced
>> or not, and still you can change a return value when tracing.
>> (But a drawback here is that a tracer will see -ENOSYS in x0 even at syscall entry
>> for syscall(-1).)
>
> But it's exactly these drawbacks that I'm objected to. syscall(-1) shouldn't
> be treated any differently to syscall(42) with respect to restarting,
> exactly like x86.
Can you elaborate a bit more as to "restarting?"
We can't make any assumption about the number of arguments taken by *invalid* syscall(-1)
and so changing a value in x0 (or any other registers) doesn't make any difference.
()
-Takahiro AKASHI
> Will
>
next prev parent reply other threads:[~2014-11-25 7:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 1:10 [PATCH v8 0/6] arm64: add seccomp support AKASHI Takahiro
2014-11-18 1:10 ` [PATCH v8 1/6] arm64: ptrace: add NT_ARM_SYSTEM_CALL regset AKASHI Takahiro
2014-11-18 1:10 ` [PATCH v8 2/6] arm64: ptrace: allow tracer to skip a system call AKASHI Takahiro
2014-11-18 14:04 ` Will Deacon
2014-11-19 8:46 ` AKASHI Takahiro
2014-11-19 19:06 ` Will Deacon
2014-11-20 5:13 ` AKASHI Takahiro
2014-11-20 5:52 ` AKASHI Takahiro
2014-11-25 13:56 ` Will Deacon
2014-11-20 19:17 ` Will Deacon
2014-11-25 7:42 ` AKASHI Takahiro [this message]
2014-11-25 10:30 ` Will Deacon
2014-11-25 14:14 ` Russell King - ARM Linux
2014-11-18 1:10 ` [PATCH v8 3/6] asm-generic: add generic seccomp.h for secure computing mode 1 AKASHI Takahiro
2014-11-18 1:10 ` [PATCH v8 4/6] arm64: add seccomp syscall for compat task AKASHI Takahiro
2014-11-18 1:10 ` [PATCH v8 5/6] arm64: add SIGSYS siginfo " AKASHI Takahiro
2014-11-18 1:10 ` [PATCH v8 6/6] arm64: add seccomp support AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547432D2.7000909@linaro.org \
--to=takahiro.akashi@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox