From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH resend] serial: of-serial: fetch line number from DT
Date: Tue, 25 Nov 2014 17:24:48 +0300 [thread overview]
Message-ID: <54749130.9050901@cogentembedded.com> (raw)
In-Reply-To: <1416904016-5567-1-git-send-email-dev@lynxeye.de>
Hello.
On 11/25/2014 11:26 AM, Lucas Stach wrote:
> The general agreed way to specify a fixed line number
> for a serial console is to provide a "serial" alias
> in the devicetree. Start parsing this property in
> of_serial.
> Signed-off-by: Lucas Stach <dev@lynxeye•de>
> Acked-by: Olof Johansson <olof@lixom•net>
> ---
> As 3.16-rc6 landed the fix to avoid the regression that this patch
> was causing on Tegra it should be safe to reapply it.
> ---
> drivers/tty/serial/of_serial.c | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 8bc2563..920a831 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -101,6 +101,10 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
> if (of_property_read_u32(np, "fifo-size", &prop) == 0)
> port->fifosize = prop;
>
> + /* Check for a fixed line number */
> + if ((ret = of_alias_get_id(np, "serial")) >= 0)
Don't use assignment in the *if* statement. If you would have ran your
patch thru scripts/checkpatch.pl, it would have complained about that.
> + port->line = ret;
> +
WBR, Sergei
prev parent reply other threads:[~2014-11-25 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 8:26 [PATCH resend] serial: of-serial: fetch line number from DT Lucas Stach
2014-11-25 14:24 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54749130.9050901@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox