public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: zyw@rock-chips•com (Chris Zhong)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v9 4/4] ARM: dts: rockchip: add suspend settings for rk3288-evb-rk808
Date: Thu, 27 Nov 2014 08:56:16 +0800	[thread overview]
Message-ID: <547676B0.9030001@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=V29zCpcEHE+rq6q_6SOZ_NOJgc5FiwmJ9jnRZK4mMUhw@mail.gmail.com>


On 11/27/2014 06:52 AM, Doug Anderson wrote:
> Chris,
>
> On Mon, Nov 24, 2014 at 11:32 PM, Chris Zhong <zyw@rock-chips•com> wrote:
>>                          vcc_ddr: DCDC_REG3 {
>>                                  regulator-always-on;
>>                                  regulator-boot-on;
>>                                  regulator-name = "vcc_ddr";
>> +                               regulator-suspend-mem-enabled;
> The "regulator-suspend-mem-enabled" is not an upstream property and
> isn't doing anything.  It should be removed.
>
> Possibly this is something Heiko could do when applying  (depends on
> what he wants) if no other spins are required.
>>                          vcc_18: LDO_REG7 {
>> @@ -128,6 +163,11 @@
>>                                  regulator-min-microvolt = <1800000>;
>>                                  regulator-max-microvolt = <1800000>;
>>                                  regulator-name = "vcc_18";
>> +                               regulator-suspend-mem-microvolt = <1800000>;
> Another non-upstream property: regulator-suspend-mem-microvolt
Ah, missed these two. I should remove all the regulator-suspend-mem-*, 
they are from Gerrit.
Thank you.
>
>
>

      reply	other threads:[~2014-11-27  0:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25  7:32 [PATCH v9 0/4] The 1st version of suspend for RK3288 Chris Zhong
2014-11-25  7:32 ` [PATCH v9 1/4] ARM: rockchip: add suspend and resume " Chris Zhong
2014-11-25  7:32 ` [PATCH v9 3/4] ARM: dts: add RK3288 suspend support Chris Zhong
2014-12-01  5:26   ` Doug Anderson
2014-12-01  8:56     ` Chris Zhong
2014-11-25  7:32 ` [PATCH v9 4/4] ARM: dts: rockchip: add suspend settings for rk3288-evb-rk808 Chris Zhong
2014-11-26 22:52   ` Doug Anderson
2014-11-27  0:56     ` Chris Zhong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547676B0.9030001@rock-chips.com \
    --to=zyw@rock-chips$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox