From: cw00.choi@samsung•com (Chanwoo Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 11/19] clk: samsung: exynos5433: Add clocks for CMU_BUS{0|1|2} domains
Date: Thu, 27 Nov 2014 21:14:42 +0900 [thread overview]
Message-ID: <547715B2.3070508@samsung.com> (raw)
In-Reply-To: <54771518.1010004@samsung.com>
Hi Sylwester,
On 11/27/2014 09:12 PM, Sylwester Nawrocki wrote:
> Hi,
>
> On 27/11/14 12:56, Chanwoo Choi wrote:
>> On 11/27/2014 08:41 PM, Arnd Bergmann wrote:
>>>> On Thursday 27 November 2014 16:35:08 Chanwoo Choi wrote:
>>>>>> + - "samsung,exynos5433-cmu-bus0", "samsung,exynos5433-cmu-bus1"
>>>>>> + and "samsung,exynos5433-cmu-bus2" - clock controller compatible for CMU_BUS
>>>>>> + which generates global data buses clock and global peripheral buses clock.
>>>>>>
>>>>>> - reg: physical base address of the controller and length of memory mapped
>>>>>> region.
>>>>>>
>>>>
>>>> This looks like you are duplicating the bindings and the code, but
>>>> it's really the same hardware multiple times with minor variations
>>>> that you should be able to describe properly here. Why not make
>>>> three nodes with the same compatible string and have them handled
>>>> by the same code?
>>
>> Each CMU_BUSx domain of Exynos5433 have different base address as following:
>> - CMU_BUS0's base address and range : 0x1360_0000 ~ 0x1360_0b04
>> - CMU_BUS1's base address and range : 0x1480_0000 ~ 0x1480_0b04
>> - CMU_BUS2's base address and range : 0x1340_0000 ~ 0x1340_0b04
>>
>> So, I implement CMU_BUSx domain which has each compatible string.
>
> You can always have multiple entries in the reg property. I've done
> something like this for the exynos4415 CMU_ISPx units:
>
> cmu_isp: clock-controller at 12060000 {
> compatible = "samsung,exynos4415-cmu-isp";
> reg = <0x12060000 0xB10>, <0x12070000 0xB10>;
> #clock-cells = <1>;
>
> assigned-clocks = <&cmu CLK_FOUT_ISP_PLL>;
> assigned-clock-rates = <300000000>;
> };
Thanks for your guide.
I'll re-implment CMU_BUSx domain according to your guide.
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2014-11-27 12:14 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 7:34 [PATCH 00/19] arm64: Add the support for new 64-bit Exynos5433 SoC Chanwoo Choi
2014-11-27 7:34 ` [PATCH 01/19] pinctrl: exynos: Add support for Exynos5433 Chanwoo Choi
2014-11-27 10:26 ` [01/19] " Pankaj Dubey
2014-11-27 10:49 ` Chanwoo Choi
2014-11-27 11:45 ` [PATCH 01/19] " Arnd Bergmann
2014-11-27 12:14 ` Tomasz Figa
2014-11-27 12:36 ` Arnd Bergmann
2014-12-28 11:21 ` Tomasz Figa
2014-12-28 23:33 ` Chanwoo Choi
2014-11-27 7:34 ` [PATCH 02/19] clk: samsung: Add binding documentation for Exynos5433 clock controller Chanwoo Choi
2014-11-27 11:21 ` Mark Rutland
2014-11-27 11:29 ` Chanwoo Choi
2014-11-27 7:35 ` [PATCH 03/19] clk: samsung: exynos5433: Add clocks using common clock framework Chanwoo Choi
2014-11-27 11:48 ` [03/19] " Pankaj Dubey
2014-11-27 12:53 ` Chanwoo Choi
2014-11-28 1:57 ` Chanwoo Choi
2014-11-27 7:35 ` [PATCH 04/19] clk: samsung: exynos5433: Add MUX clocks of CMU_TOP domain Chanwoo Choi
2014-11-27 7:35 ` [PATCH 05/19] clk: samsung: exynos5433: Add clocks for CMU_PERIC domain Chanwoo Choi
2014-11-27 7:35 ` [PATCH 06/19] clk: samsung: exynos5433: Add clocks for CMU_PERIS domain Chanwoo Choi
2014-11-27 7:35 ` [PATCH 07/19] clk: samsung: exynos5433: Add clocks for CMU_G2D domain Chanwoo Choi
2014-11-27 7:35 ` [PATCH 08/19] clk: samsung: exynos5433: Add clocks for CMU_MIF domain Chanwoo Choi
2014-11-27 7:35 ` [PATCH 09/19] clk: samsung: exynos5433: Add clocks for CMU_DISP domain Chanwoo Choi
2014-11-27 7:35 ` [PATCH 10/19] clk: samsung: exynos5433: Add clocks for CMU_AUD domain Chanwoo Choi
2014-11-27 7:35 ` [PATCH 11/19] clk: samsung: exynos5433: Add clocks for CMU_BUS{0|1|2} domains Chanwoo Choi
2014-11-27 11:41 ` Arnd Bergmann
2014-11-27 11:56 ` Chanwoo Choi
2014-11-27 12:12 ` Sylwester Nawrocki
2014-11-27 12:14 ` Chanwoo Choi [this message]
2014-11-27 12:35 ` Arnd Bergmann
2014-11-27 12:58 ` Chanwoo Choi
2014-11-27 13:15 ` Arnd Bergmann
[not found] ` <CAGTfZH3KmwhJNFdmeWnujbbUbtLf5vSi6i2dbV62DeCtV7n4TQ@mail.gmail.com>
2014-11-27 14:02 ` Arnd Bergmann
2014-11-27 15:17 ` Chanwoo Choi
2014-11-27 15:33 ` Arnd Bergmann
2014-11-27 15:44 ` Chanwoo Choi
2014-11-27 15:51 ` Arnd Bergmann
2014-11-27 15:58 ` Chanwoo Choi
2014-11-27 7:35 ` [PATCH 12/19] clk: samsung: exynos5433: Add missing clocks for CMU_FSYS domain Chanwoo Choi
2014-11-27 7:35 ` [PATCH 13/19] clk: samsung: exynos5433: Add clocks for CMU_G3D domain Chanwoo Choi
2014-11-27 7:35 ` [PATCH 14/19] clk: samsung: exynos5433: Add clocks for CMU_GSCL domain Chanwoo Choi
2014-11-27 7:35 ` [PATCH 15/19] arm64: exynos5433: Enable ARMv8-based Exynos5433 SoC support Chanwoo Choi
2014-11-27 11:18 ` Catalin Marinas
2014-11-27 11:22 ` Chanwoo Choi
2014-11-27 7:35 ` [PATCH 16/19] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC Chanwoo Choi
2014-11-27 10:26 ` Marc Zyngier
2014-11-28 13:51 ` Chanwoo Choi
2014-11-27 11:18 ` Mark Rutland
2014-11-28 13:18 ` Chanwoo Choi
2014-11-28 14:00 ` Mark Rutland
2014-12-01 2:21 ` Chanwoo Choi
2014-12-02 10:42 ` Mark Rutland
2014-11-27 7:35 ` [PATCH 17/19] arm64: dts: exynos: Add MSHC dt node for Exynos5433 Chanwoo Choi
2014-11-27 7:35 ` [PATCH 18/19] arm64: dts: exynos: Add SPI/PDMA " Chanwoo Choi
2014-11-27 7:35 ` [PATCH 19/19] serial: samsung: Add the support for Exynos5433 SoC Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547715B2.3070508@samsung.com \
--to=cw00.choi@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox