From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm64: ARM: Fix the Generic Timers interrupt active level description
Date: Thu, 27 Nov 2014 15:48:47 +0000 [thread overview]
Message-ID: <547747DF.9070402@arm.com> (raw)
In-Reply-To: <20141127153453.GR828@e106497-lin.cambridge.arm.com>
On 27/11/14 15:34, Liviu Dudau wrote:
> On Thu, Nov 27, 2014 at 02:43:38PM +0000, Marc Zyngier wrote:
>> On 27/11/14 14:36, Liviu Dudau wrote:
>>> The Cortex-A5x TRM states in paragraph "9.2 Generic Timer functional
>>> description" that generic timers provide an active-LOW interrupt
>>> output. Fix the device trees to correctly describe this.
>>>
>>> While doing this update the CPU mask to match the number of described
>>> CPUs as well.
>>>
>>> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm•com>
>>> ---
>>>
>>> Arnd, Olof: This is on top of linux-next/master as it patches the Juno
>>> as well as all the other ARM DTs.
>>>
>>> arch/arm64/boot/dts/arm/foundation-v8.dts | 8 ++++----
>>> arch/arm64/boot/dts/arm/juno.dts | 8 ++++----
>>> arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 8 ++++----
>>> 3 files changed, 12 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dts b/arch/arm64/boot/dts/arm/foundation-v8.dts
>>> index 4a06090..27f3296 100644
>>> --- a/arch/arm64/boot/dts/arm/foundation-v8.dts
>>> +++ b/arch/arm64/boot/dts/arm/foundation-v8.dts
>>> @@ -78,10 +78,10 @@
>>>
>>> timer {
>>> compatible = "arm,armv8-timer";
>>> - interrupts = <1 13 0xff01>,
>>> - <1 14 0xff01>,
>>> - <1 11 0xff01>,
>>> - <1 10 0xff01>;
>>> + interrupts = <1 13 0xf08>,
>>> + <1 14 0xf08>,
>>> + <1 11 0xf08>,
>>> + <1 10 0xf08>;
>>> clock-frequency = <100000000>;
>>> };
>>>
>>> diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts
>>> index 097ecc4..cb3073e 100644
>>> --- a/arch/arm64/boot/dts/arm/juno.dts
>>> +++ b/arch/arm64/boot/dts/arm/juno.dts
>>> @@ -98,10 +98,10 @@
>>>
>>> timer {
>>> compatible = "arm,armv8-timer";
>>> - interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_EDGE_RISING)>,
>>> - <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_EDGE_RISING)>,
>>> - <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_EDGE_RISING)>,
>>> - <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_EDGE_RISING)>;
>>> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>,
>>> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>,
>>> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>,
>>> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>;
>>> };
>>>
>>> pmu {
>>> diff --git a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts
>>> index 572005e..efc59b3 100644
>>> --- a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts
>>> +++ b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts
>>> @@ -81,10 +81,10 @@
>>>
>>> timer {
>>> compatible = "arm,armv8-timer";
>>> - interrupts = <1 13 0xff01>,
>>> - <1 14 0xff01>,
>>> - <1 11 0xff01>,
>>> - <1 10 0xff01>;
>>> + interrupts = <1 13 0xf08>,
>>> + <1 14 0xf08>,
>>> + <1 11 0xf08>,
>>> + <1 10 0xf08>;
>>> clock-frequency = <100000000>;
>>> };
>>>
>>>
>>
>> Sorry, but that's wrong. Despite the *cores* having an level-low output,
>> the GIC only triggers on *level-high*. Yes, there is probably an
>> inverter in between.
>
> BTW, should I also update the bindings example to get this right?
Definitely. I'm pretty sure I got it wrong too at some point...
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-11-27 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 14:36 [PATCH] arm64: ARM: Fix the Generic Timers interrupt active level description Liviu Dudau
2014-11-27 14:43 ` Marc Zyngier
2014-11-27 15:33 ` Liviu Dudau
2014-11-27 15:34 ` Liviu Dudau
2014-11-27 15:48 ` Marc Zyngier [this message]
2014-11-28 11:50 ` Liviu Dudau
2014-11-28 21:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547747DF.9070402@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox