From: dingtianhong@huawei•com (Ding Tianhong)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v8 3/3] net: hisilicon: new hip04 ethernet driver
Date: Sun, 7 Dec 2014 11:28:55 +0800 [thread overview]
Message-ID: <5483C977.2060308@huawei.com> (raw)
In-Reply-To: <5483A279.5000503@suse.de>
On 2014/12/7 8:42, Alexander Graf wrote:
> On 19.04.14 03:13, Zhangfei Gao wrote:
>> Support Hisilicon hip04 ethernet driver, including 100M / 1000M controller.
>> The controller has no tx done interrupt, reclaim xmitted buffer in the poll.
>>
>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro•org>
>
> Is this driver still supposed to go upstream? I presume this was the
> last submission and it's been quite some time ago :)
>
yes, it is really a long time, but The hip04 did not support tx irq,
we couldn't get any better idea to fix this defect, do you have any suggestion?
Regards
Ding
>> ---
>> drivers/net/ethernet/hisilicon/Makefile | 2 +-
>> drivers/net/ethernet/hisilicon/hip04_eth.c | 846 ++++++++++++++++++++++++++++
>> 2 files changed, 847 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/net/ethernet/hisilicon/hip04_eth.c
>>
>> diff --git a/drivers/net/ethernet/hisilicon/Makefile b/drivers/net/ethernet/hisilicon/Makefile
>> index 1d6eb6e..17dec03 100644
>
> [...]
>
>> +static irqreturn_t hip04_mac_interrupt(int irq, void *dev_id)
>> +{
>> + struct net_device *ndev = (struct net_device *) dev_id;
>> + struct hip04_priv *priv = netdev_priv(ndev);
>> + struct net_device_stats *stats = &ndev->stats;
>> + u32 ists = readl_relaxed(priv->base + PPE_INTSTS);
>> +
>> + writel_relaxed(DEF_INT_MASK, priv->base + PPE_RINT);
>> +
>> + if (unlikely(ists & DEF_INT_ERR)) {
>> + if (ists & (RCV_NOBUF | RCV_DROP))
>> + stats->rx_errors++;
>> + stats->rx_dropped++;
>> + netdev_err(ndev, "rx drop\n");
>
> Why would a user want to see this as a dmesg error? We already have
> stats for packet drops, no?
>
>> + if (ists & TX_DROP) {
>> + stats->tx_dropped++;
>> + netdev_err(ndev, "tx drop\n");
>
> Same here.
>
>> + }
>> + }
>> +
>> + if (ists & RCV_INT) {
>> + /* disable rx interrupt */
>> + priv->reg_inten &= ~(RCV_INT);
>> + writel_relaxed(priv->reg_inten, priv->base + PPE_INTEN);
>> + napi_schedule(&priv->napi);
>> + }
>> +
>> + return IRQ_HANDLED;
>> +}
>
> [...]
>
>> +
>> +static const struct of_device_id hip04_mac_match[] = {
>> + { .compatible = "hisilicon,hip04-mac" },
>> + { }
>> +};
>
> This is missing the magic macro that actually would make module aliases
> work.
>
>
> Alex
>
>> +
>> +static struct platform_driver hip04_mac_driver = {
>> + .probe = hip04_mac_probe,
>> + .remove = hip04_remove,
>> + .driver = {
>> + .name = DRV_NAME,
>> + .owner = THIS_MODULE,
>> + .of_match_table = hip04_mac_match,
>> + },
>> +};
>> +module_platform_driver(hip04_mac_driver);
>> +
>> +MODULE_DESCRIPTION("HISILICON P04 Ethernet driver");
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_ALIAS("platform:hip04-ether");
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> .
>
next prev parent reply other threads:[~2014-12-07 3:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 1:12 [PATCH v8 0/3] add hisilicon hip04 ethernet driver Zhangfei Gao
2014-04-19 1:12 ` [PATCH v8 1/3] Documentation: add Device tree bindings for Hisilicon hip04 ethernet Zhangfei Gao
2014-04-19 1:12 ` [PATCH v8 2/3] net: hisilicon: new hip04 MDIO driver Zhangfei Gao
2014-04-21 17:58 ` Sergei Shtylyov
2014-04-21 18:03 ` Florian Fainelli
2014-04-21 18:21 ` Sergei Shtylyov
2014-04-22 6:03 ` zhangfei
2014-04-22 8:22 ` Arnd Bergmann
2014-04-22 14:16 ` zhangfei
2014-04-22 14:30 ` Arnd Bergmann
2014-04-22 14:58 ` zhangfei
2014-04-24 12:28 ` Arnd Bergmann
2014-04-24 13:00 ` zhangfei
2014-04-19 1:13 ` [PATCH v8 3/3] net: hisilicon: new hip04 ethernet driver Zhangfei Gao
2014-12-07 0:42 ` Alexander Graf
2014-12-07 3:28 ` Ding Tianhong [this message]
2014-12-07 9:49 ` Alexander Graf
2014-12-07 20:09 ` Arnd Bergmann
2014-12-08 1:48 ` Ding Tianhong
2014-12-10 3:51 ` Ding Tianhong
2014-12-10 6:45 ` Ding Tianhong
2014-12-10 9:35 ` Arnd Bergmann
2014-12-10 16:07 ` David Miller
2014-12-10 16:36 ` Arnd Bergmann
2014-12-10 17:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5483C977.2060308@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox