From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/4] GICv3: add 32bit compatibility
Date: Fri, 12 Dec 2014 16:52:31 +0000 [thread overview]
Message-ID: <548B1D4F.4030701@arm.com> (raw)
In-Reply-To: <548B1A47.7060301@arm.com>
On 12/12/14 16:39, Andre Przywara wrote:
> Hi Jean-Philippe,
>
> On 11/12/14 14:23, Jean-Philippe Brucker wrote:
>> This series adds 32bit compatibility to Marc's GICv3 driver. Only SGIs,
>> PPIs and SPIs support is present. No ITS nor virtualisation.
>>
>> It is based on 3.18.
>>
>> Jean-Philippe Brucker (4):
>> arm64: GICv3: refactor the AArch64 specific parts
>> arm64: GICv3: change unsigned types for AArch32 compatibility
>> arm64: GICv3: Specialize readq and writeq accesses
>> ARM: add 32bit support to GICv3
>>
>> arch/arm/include/asm/arch_gicv3.h | 182 ++++++++++++++++++++++++++++++++++++
>> arch/arm64/include/asm/arch_gicv3.h | 141 ++++++++++++++++++++++++++++
>> drivers/irqchip/irq-gic-v3.c | 69 ++++----------
>> include/linux/irqchip/arm-gic-v3.h | 95 +++----------------
>> 4 files changed, 356 insertions(+), 131 deletions(-)
>> create mode 100644 arch/arm/include/asm/arch_gicv3.h
>> create mode 100644 arch/arm64/include/asm/arch_gicv3.h
>
> so if I compile this with CONFIG_KVM_ARM_VGIC on, I get a compilation error:
> LD init/built-in.o
> arch/arm/kvm/built-in.o: In function `svc_die_str':
> arch_timer.c:(.rodata+0xf7c): undefined reference to `vgic_v3_probe'
> make[2]: *** [vmlinux] Error 1
>
> The svc_die_str reference is probably bogus, but if I protect the
> vgic_v3_probe reference in virt/kvm/arm/vgic.c with "#ifdef ARM64" it
> compiles fine. Disabling CONFIG_KVM_ARM_VGIC in the .config also fixes
> this also.
That's an absolute no-no. I want to be able to run the exact same kernel
as a KVM host *and* a guest. So disabling the vgic can never be the
right solution.
Either wrapping the vgic_v3_probe reference with CONFIG_ARM64 or having
a non "static inline" vgic_v3_probe for 32bit are acceptable solutions.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2014-12-12 16:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 14:23 [PATCH 0/4] GICv3: add 32bit compatibility Jean-Philippe Brucker
2014-12-11 14:23 ` [PATCH 1/4] arm64: GICv3: refactor the AArch64 specific parts Jean-Philippe Brucker
2014-12-11 14:23 ` [PATCH 2/4] arm64: GICv3: change unsigned types for AArch32 compatibility Jean-Philippe Brucker
2014-12-18 13:27 ` Vladimir Murzin
2014-12-18 14:42 ` Jean-Philippe Brucker
2014-12-11 14:23 ` [PATCH 3/4] arm64: GICv3: Specialize readq and writeq accesses Jean-Philippe Brucker
2014-12-11 14:23 ` [PATCH 4/4] ARM: add 32bit support to GICv3 Jean-Philippe Brucker
2014-12-11 14:32 ` Russell King - ARM Linux
2014-12-11 15:40 ` Marc Zyngier
2014-12-11 16:57 ` Jean-Philippe Brucker
2014-12-11 17:23 ` Marc Zyngier
2014-12-11 17:38 ` [PATCH 0/4] GICv3: add 32bit compatibility Marc Zyngier
2014-12-12 16:39 ` Andre Przywara
2014-12-12 16:52 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548B1D4F.4030701@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox