From: pankaj.dubey@samsung•com (Pankaj Dubey)
To: linux-arm-kernel@lists•infradead.org
Subject: kernel panic when booting on exynos 5440
Date: Thu, 25 Dec 2014 16:23:46 +0530 [thread overview]
Message-ID: <549BECBA.4060707@samsung.com> (raw)
In-Reply-To: <CACVXFVMOmq4rzXtaLNFn2NE-X=__dTJFANWtuJZS9m9szV0JuQ@mail.gmail.com>
On Thursday 25 December 2014 04:13 PM, Ming Lei wrote:
> On Thu, Dec 25, 2014 at 6:32 PM, Pankaj Dubey <pankaj.dubey@samsung•com> wrote:
>> +CC: Thomas Abraham
>>
>> Hi Ming,
>>
>> On Thursday 25 December 2014 02:18 PM, Ming Lei wrote:
>>>
>>> Hi Pankaj,
>>>
>>> In your commit fce9e5bb2(ARM: EXYNOS: Add support for
>>> mapping PMU base address via DT), 'pmu_base_addr' is
>>> only parsed for very limited machines from the table of
>>> 'exynos_dt_pmu_match'. For other boards, 'pmu_base_addr'
>>> will keep its default value of null, then panic() is triggered.
>>>
>>
>> Yes, it will.
>> As exynos5440 DT does not have PMU device node, neither above mentioned
>> patch added corresponding matching device_id.
>> If I remember correctly, I might have missed this because exynos5440 DT was
>> not having PMU node.
>>
>>> What do you think about the problem?
>>
>>
>> I missed this part, and I should have taken care of this in original patch
>> itself. Well as of now I can think of only one solution that if we really
>> want to keep support for exynos5440 in mainline kernel, to avoid above issue
>> we should skip pmu mapping for exynos5440. In this case following patch will
>> do this work.
>>
>> Also I will like to know from Kukjin that what best can be done now.
>> If he is OK with below solution I can post the same.
>>
>> ---------------------------------------------------------------
>>
>> Subject: [PATCH] ARM: EXYNOS: do not try to map PMU for exynos5440
>>
>> Commit id: 2e94ac42898f84d76e3c21dd91bc is not taking care
>> of mapping of exynos5440 PMU register which will result in kernel panic.
>> As of now let's avoid mapping of exynos5440 PMU.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
>> ---
>> arch/arm/mach-exynos/exynos.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
>> index c13d083..1891b8c 100644
>> --- a/arch/arm/mach-exynos/exynos.c
>> +++ b/arch/arm/mach-exynos/exynos.c
>> @@ -208,7 +208,8 @@ static void __init exynos_init_irq(void)
>> * DT is not unflatten so we can't use DT APIs before
>> * init_irq
>> */
>> - exynos_map_pmu();
>> + if (!of_machine_is_compatible("samsung,exynos5440"))
>> + exynos_map_pmu();
>> }
>
> If I remember correctly, there are other SoCs which have not been
> included in the pmu mapping list, and looks these SoCs need
> to be handled too.
>
As far as I can see in today's linux-next and kgene/for-next tree, only
exynos5440 PMU mapping is missing. If I am missing anything please
specify exact SoC name, which you think need to be handled.
Thanks,
Pankaj Dubey
>
> Thanks,
> Ming Lei
>
next prev parent reply other threads:[~2014-12-25 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 8:48 kernel panic when booting on exynos 5440 Ming Lei
2014-12-25 10:32 ` Pankaj Dubey
2014-12-25 10:43 ` Ming Lei
2014-12-25 10:53 ` Pankaj Dubey [this message]
2014-12-26 1:39 ` Ming Lei
2015-01-04 2:57 ` Ming Lei
2015-01-05 10:13 ` Kukjin Kim
2015-01-05 12:13 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549BECBA.4060707@samsung.com \
--to=pankaj.dubey@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox