From: hdegoede@redhat•com (Hans de Goede)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 12/13] ARM: dts: sun6i: Add sun6i-a31s.dtsi
Date: Mon, 05 Jan 2015 10:31:05 +0100 [thread overview]
Message-ID: <54AA59D9.7030909@redhat.com> (raw)
In-Reply-To: <20150105090825.GA31311@lukather>
Hi,
On 05-01-15 10:08, Maxime Ripard wrote:
> Hi,
>
> On Mon, Dec 22, 2014 at 02:46:12PM +0100, Hans de Goede wrote:
>> On 21-12-14 23:39, Maxime Ripard wrote:
>>> On Sat, Dec 20, 2014 at 11:24:55AM +0100, Hans de Goede wrote:
<snip>
>>>>> Given your previous changes, you should also update the enable-method.
>>>>
>>>> I've not added a new compatible for the enable-method, given that
>>>> this is the exact same die, so the 2 are 100?% compatible, just like you
>>>> insisted that "allwinner,sun4i-a10-mod0-clk" should be used for the ir-clk
>>>> since it was 100% compatible to that I believe that the enable method
>>>> should use the existing compatible and not invent a new one for something
>>>> which is 100% compatible.
>>>
>>> Yeah, you have a point and I agree, but your patch 3 does add a
>>> CPU_METHOD_OF_DECLARE for the A31s.
>>
>> Ah right, it does, my bad.
>>
>>> Since I was going to push the branch now that 3.19-rc1 is out, do you
>>> want me to edit your patch before doing so?
>>
>> Yes, please drop the addition of the extra CPU_METHOD_OF_DECLARE, or let
>> me know if you want a new version instead.
>
> I just modified it, and pushed it, no need to resend it.
Thanks, while looking at your dt-for-3.20 branch I noticed that you've
merged v2 of "ARM: dts: sun6i: Add ir node", I did a v3 adding an ir:
label to the node, which I noticed was missing because you asked me to
move the a31s dt stuff to moving label references, can you fix this up, or
do you want me to do a follow up patch ?
Note that having this fixed is a pre-req for the csq-cs908 dts patch.
Regards,
Hans
next prev parent reply other threads:[~2015-01-05 9:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 17:18 [PATCH v2 00/13] sun6i: Add A31s and ir support Hans de Goede
2014-12-17 17:18 ` [PATCH v2 01/13] pinctrl: sun6i: Add some missing functions Hans de Goede
2014-12-19 18:17 ` Maxime Ripard
2015-01-13 14:29 ` Linus Walleij
2014-12-17 17:18 ` [PATCH v2 02/13] pinctrl: sun6i: Add A31s pinctrl support Hans de Goede
2014-12-19 18:20 ` Maxime Ripard
2015-01-13 14:31 ` Linus Walleij
2014-12-17 17:18 ` [PATCH v2 03/13] ARM: sunxi: Add "allwinner, sun6i-a31s" to mach-sunxi Hans de Goede
2014-12-19 18:22 ` [PATCH v2 03/13] ARM: sunxi: Add "allwinner,sun6i-a31s" " Maxime Ripard
2014-12-17 17:18 ` [PATCH v2 04/13] rc: sunxi-cir: Add support for an optional reset controller Hans de Goede
2014-12-18 2:48 ` [linux-sunxi] " Chen-Yu Tsai
2014-12-18 8:50 ` Hans de Goede
2014-12-19 18:17 ` Maxime Ripard
2014-12-20 10:20 ` Hans de Goede
2015-01-19 14:10 ` Chen-Yu Tsai
2015-01-19 14:17 ` Hans de Goede
2015-01-19 14:24 ` Chen-Yu Tsai
2014-12-17 17:18 ` [PATCH v2 05/13] rc: sunxi-cir: Add support for the larger fifo found on sun5i and sun6i Hans de Goede
2014-12-17 17:18 ` [PATCH v2 06/13] clk: sunxi: Make the mod0 clk driver also a platform driver Hans de Goede
2014-12-19 18:24 ` Maxime Ripard
2014-12-20 10:25 ` Hans de Goede
2014-12-17 17:18 ` [PATCH v2 07/13] mfd: sun6i-prcm: Add support for the ir-clk Hans de Goede
2014-12-18 8:41 ` Lee Jones
2014-12-18 8:53 ` Hans de Goede
2014-12-18 9:19 ` Lee Jones
2014-12-17 17:18 ` [PATCH v2 08/13] ARM: dts: sun6i: Add ir_clk node Hans de Goede
2014-12-19 18:25 ` Maxime Ripard
2014-12-17 17:18 ` [PATCH v2 09/13] ARM: dts: sun6i: Add ir node Hans de Goede
2014-12-19 18:25 ` Maxime Ripard
2014-12-17 17:18 ` [PATCH v2 10/13] ARM: dts: sun6i: Add pinmux settings for the ir pins Hans de Goede
2014-12-17 17:18 ` [PATCH v2 11/13] ARM: dts: sun6i: Enable ir receiver on the Mele M9 Hans de Goede
2014-12-19 18:27 ` Maxime Ripard
2014-12-17 17:18 ` [PATCH v2 12/13] ARM: dts: sun6i: Add sun6i-a31s.dtsi Hans de Goede
2014-12-19 18:34 ` Maxime Ripard
2014-12-20 10:24 ` Hans de Goede
2014-12-21 22:39 ` Maxime Ripard
2014-12-22 13:46 ` Hans de Goede
2015-01-05 9:08 ` Maxime Ripard
2015-01-05 9:31 ` Hans de Goede [this message]
2015-01-06 10:03 ` Maxime Ripard
2014-12-17 17:18 ` [PATCH v2 13/13] ARM: dts: sun6i: Add dts file for CSQ CS908 board Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AA59D9.7030909@redhat.com \
--to=hdegoede@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox