From: vigneshr@ti•com (Vignesh R)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC
Date: Wed, 7 Jan 2015 11:17:20 +0530 [thread overview]
Message-ID: <54ACC868.7040801@ti.com> (raw)
In-Reply-To: <20150102170933.GB3298@atomide.com>
On Friday 02 January 2015 10:39 PM, Tony Lindgren wrote:
> * Vignesh R <vigneshr@ti•com> [141223 23:07]:
>> The charge delay value is by default 0x400. But it can be set to lower
>> values on some boards, as long as false pen-ups are avoided. Lowering the
>> value increases the sampling rate (though current sampling rate is
>> sufficient for TSC operation). In some boards, the value has to be
>> increased to avoid false pen-up events. Hence, charge delay has been
>> made a DT parameter.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti•com>
>
> Assuming this binding makes sense for the input people, there should
> be no conflicts merging this patch along with the rest of the series
> via the input tree.
>
I will post new version moving documentation to driver code and keeping
DT changes as a separate patch.
> Sounds like this value probably depends on the size of the touchscreen
> for the capacitance, so a numeric value is really needed here.
Its not just dependent on the size of the touchscreen. It varies based
on the individual setups.
> I would personally prefer generic bindings in general, but in any case
There isn't any generic binding that corresponds to charge-delay.
Nothing as been pointed out by input maintainer either.
Regards
Vignesh
> please feel free to merge along with the other input patches:
>
> Acked-by: Tony Lindgren <tony@atomide•com>
>
>
>> ---
>> v4:
>> - Set charge delay to 0x400 as default. Most devices function normally
>> at this value
>>
>> .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 15 +++++++++++++++
>> arch/arm/boot/dts/am335x-evm.dts | 1 +
>> 2 files changed, 16 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
>> index 878549ba814d..6df5028a4ad3 100644
>> --- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt
>> @@ -28,6 +28,20 @@ Required properties:
>> ti,adc-channels: List of analog inputs available for ADC.
>> AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.
>>
>> +Optional properties:
>> +- child "tsc"
>> + ti,charge-delay: Length of touch screen charge delay step in terms of
>> + ADC clock cycles. Charge delay value should be large
>> + in order to avoid false pen-up events. This value
>> + affects the overall sampling speed, hence need to be
>> + kept as low as possible, while avoiding false pen-up
>> + event. Start from a lower value, say 0x400, and
>> + increase value until false pen-up events are avoided.
>> + The pen-up detection happens immediately after the
>> + charge step, so this does in fact function as a
>> + hardware knob for adjusting the amount of "settling
>> + time".
>> +
>> Example:
>> tscadc: tscadc at 44e0d000 {
>> compatible = "ti,am3359-tscadc";
>> @@ -36,6 +50,7 @@ Example:
>> ti,x-plate-resistance = <200>;
>> ti,coordiante-readouts = <5>;
>> ti,wire-config = <0x00 0x11 0x22 0x33>;
>> + ti,charge-delay = <0x400>;
>> };
>>
>> adc {
>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
>> index 54f118c08db8..66342515df20 100644
>> --- a/arch/arm/boot/dts/am335x-evm.dts
>> +++ b/arch/arm/boot/dts/am335x-evm.dts
>> @@ -648,6 +648,7 @@
>> ti,x-plate-resistance = <200>;
>> ti,coordinate-readouts = <5>;
>> ti,wire-config = <0x00 0x11 0x22 0x33>;
>> + ti,charge-delay = <0x400>;
>> };
>>
>> adc {
>> --
>> 1.9.1
>>
next prev parent reply other threads:[~2015-01-07 5:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 7:03 [PATCH v5 0/6] Touchscreen performance related fixes Vignesh R
2014-12-24 7:03 ` [PATCH v5 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2014-12-24 7:03 ` [PATCH v5 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2014-12-24 7:03 ` [PATCH v5 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Vignesh R
2014-12-24 7:03 ` [PATCH v5 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC Vignesh R
2015-01-02 17:09 ` Tony Lindgren
2015-01-07 5:47 ` Vignesh R [this message]
2014-12-24 7:03 ` [PATCH v5 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-12-24 7:03 ` [PATCH v5 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ACC868.7040801@ti.com \
--to=vigneshr@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox