public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5][resend v4] of: replace Asahi Kasei Corp vendor prefix
Date: Thu, 08 Jan 2015 21:36:00 -0700	[thread overview]
Message-ID: <54AF5AB0.2050208@wwwdotorg.org> (raw)
In-Reply-To: <87egr4vcxu.wl%kuninori.morimoto.gx@renesas.com>

On 01/08/2015 08:40 PM, Kuninori Morimoto wrote:
> 
> Hi Stephen, Olof, Arnd, Rob, Andrew
> 
> I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during
> half-year (since Jun 2014) , many times. But, no-one care it.
> I don't know who is the best maintainer.
>  - Stephen : because it has Tegra ?
>  - Olof    : because it has Tegra (= ARM) ?
>  - Arnd    : because it has Tegra (= ARM) ?
>  - Matthias: because it has Tegra (= ARM SoC) ?
>  - Rob     : because DT ?
>  - Andrew  : Last chance ?
> 
> But, could you please care this patch ?
> I will re-send it again

It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively
changing a DT vendor name would need that, I think.

Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it
seems they expect it to go through some tree other than Tegra. Weren't
there a bunch of related patches along with this (e.g. updating relevant
drivers to support both prefixes?) so it was expected this patch would
be applied together with them?

>> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas•com>
>>
>> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
>> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)
>>
>> It went through the appropriate review process. But, almost all
>> Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
>> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
>>  but there are instances of "asahi-kasei,ak8975" in other dts files.
>>  And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
>> So, we made a mistake there.
>>
>> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
>> prerfix in DT file.
>> (DT compatible string vendor "asahi-kasei" appears un-documented)
>>
>> Marking it deprecated and warning with checkpatch is certainly
>> preferable. So, this patch replace "ak" to "asahi-kasei" in
>> vendor-prefixes.txt. (and fixup tegra20-seaboard)
>>
>> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
>> doesn't care about it. Because no DT is using that today.
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas•com>
>> Acked-by: Thierry Reding <treding@nvidia•com>
>> Acked-by: Alexandre Courbot <acourbot@nvidia•com>

>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt

>> -ak	Asahi Kasei Corp.

>> +asahi-kasei	Asahi Kasei Corp.

>> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts

>>  		magnetometer at c {
>> -			compatible = "ak,ak8975";
>> +			compatible = "asahi-kasei,ak8975";

  parent reply	other threads:[~2015-01-09  4:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5398AB07.4040304@wwwdotorg.org>
     [not found] ` <87sinbdk44.wl%kuninori.morimoto.gx@renesas.com>
     [not found]   ` <878ulzx6hr.wl%kuninori.morimoto.gx@gmail.com>
     [not found]     ` <20140922130026.GK3290@leverpostej>
     [not found]       ` <CAMuHMdX22z97SbGS1HDiYfJ1PXxyEN2S8D7w4sr+4bUwD+mJZw@mail.gmail.com>
     [not found]         ` <20140922132743.GM3290@leverpostej>
     [not found]           ` <87y4rfhmgl.wl%kuninori.morimoto.gx@renesas.com>
     [not found]             ` <1415845309.4269.6.camel@perches.com>
     [not found]               ` <20141113025105.GA16652@verge.net.au>
     [not found]                 ` <87vbmjhj00.wl%kuninori.morimoto.gx@renesas.com>
     [not found]                   ` <20141113110740.GE3815@sirena.org.uk>
2014-11-14  1:43                     ` [PATCH v3] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
2014-11-14  8:38                       ` Alexandre Courbot
2014-11-14  9:16                         ` Arnd Bergmann
2014-11-14  9:30                         ` Thierry Reding
2014-11-14  9:35                       ` [alsa-devel] " Thierry Reding
2014-11-17  0:51                         ` [PATCH v4] " Kuninori Morimoto
2014-11-17 10:26                           ` Sergei Shtylyov
2014-11-18  0:30                             ` [PATCH v5] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
2014-11-28  0:22                               ` [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix Kuninori Morimoto
2014-11-28 11:45                                 ` Sergei Shtylyov
2014-12-02  4:57                                   ` [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix Kuninori Morimoto
2014-12-15  3:53                                     ` [PATCH v5][resend v2] " Kuninori Morimoto
2014-12-17  2:33                                     ` [PATCH v5][resend v3] " Kuninori Morimoto
2015-01-09  3:40                                       ` [PATCH v5][resend v4] " Kuninori Morimoto
2015-01-09  3:42                                         ` [PATCH v5][resend v5] " Kuninori Morimoto
2015-01-09  4:36                                         ` Stephen Warren [this message]
2015-01-09 10:07                                           ` [PATCH v5][resend v4] " Kuninori Morimoto
2015-01-09 13:46                                             ` Rob Herring
2015-01-09 13:55                                               ` Arnd Bergmann
2015-01-09 16:04                                                 ` Mark Brown
2014-12-25  3:55                                     ` [PATCH v5][resend v6] " Kuninori Morimoto
2015-01-13 20:03                                     ` [PATCH v5][resend] " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AF5AB0.2050208@wwwdotorg.org \
    --to=swarren@wwwdotorg$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox