From: wangnan0@huawei•com (Wang Nan)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v20 01/11] ARM: probes: move all probe code to dedicate directory
Date: Fri, 9 Jan 2015 17:50:05 +0800 [thread overview]
Message-ID: <54AFA44D.1080500@huawei.com> (raw)
In-Reply-To: <1420796864.4160.6.camel@linaro.org>
On 2015/1/9 17:47, Jon Medhurst (Tixy) wrote:
> On Fri, 2015-01-09 at 10:19 +0800, Wang Nan wrote:
>> In discussion on LKML (https://lkml.org/lkml/2014/11/28/158), Russell
>> King suggests to move all probe related code to arch/arm/probes. This
>> patch does the work. Due to dependency on 'arch/arm/kernel/patch.h', this
>> patch also moves patch.h to 'arch/arm/include/asm/patch.h', and related
>> '#include' directives are also midified to '#include <asm/patch.h>'.
>>
>> Following is an overview of this patch:
>>
>> ./arch/arm/kernel/ ./arch/arm/probes/
>> |-- Makefile |-- Makefile
>> |-- probes-arm.c ==> |-- decode-arm.c
>> |-- probes-arm.h ==> |-- decode-arm.h
>> |-- probes-thumb.c ==> |-- decode-thumb.c
>> |-- probes-thumb.h ==> |-- decode-thumb.h
>> |-- probes.c ==> |-- decode.c
>> |-- probes.h ==> |-- decode.h
>> | |-- kprobes
>> | | |-- Makefile
>> |-- kprobes-arm.c ==> | |-- actions-arm.c
>> |-- kprobes-common.c ==> | |-- actions-common.c
>> |-- kprobes-thumb.c ==> | |-- actions-thumb.c
>> |-- kprobes.c ==> | |-- core.c
>> |-- kprobes.h ==> | |-- core.h
>> |-- kprobes-test-arm.c ==> | |-- test-arm.c
>> |-- kprobes-test.c ==> | |-- test-core.c
>> |-- kprobes-test.h ==> | |-- test-core.h
>> |-- kprobes-test-thumb.c ==> | `-- test-thumb.c
>> | `-- uprobes
>> | |-- Makefile
>> |-- uprobes-arm.c ==> |-- actions-arm.c
>> |-- uprobes.c ==> |-- core.c
>> |-- uprobes.h ==> `-- core.h
>> |
>> `-- patch.h ==> arch/arm/include/asm/patch.h
>>
>> Signed-off-by: Wang Nan <wangnan0@huawei•com>
>> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi•com>
>> ---
>
> Might have been good to mention what's changed in this version, I worked
> out its kgdb.c, comments below...
>
> [...]
>
>> diff --git a/arch/arm/kernel/kgdb.c b/arch/arm/kernel/kgdb.c
>> index 07db2f8..f3eb83f 100644
>> --- a/arch/arm/kernel/kgdb.c
>> +++ b/arch/arm/kernel/kgdb.c
>> @@ -16,7 +16,7 @@
>>
>> #include <asm/traps.h>
>>
>> -#include "patch.h"
>> +#include <asm/patch.h>
>
> To keep alphabetical ordering of headers this should be above the
> #include <asm/traps.h>
>
> Don't bother resending the patch, I'll just update the patch in the git
> branch I'm putting together.
>
Thanks a lot!
next prev parent reply other threads:[~2015-01-09 9:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 11:28 [PATCH v19 00/11] ARM: kprobes: OPTPROBES and other improvements Wang Nan
2015-01-05 11:29 ` [PATCH v19 01/11] ARM: probes: move all probe code to dedicate directory Wang Nan
2015-01-09 2:19 ` [PATCH v20 " Wang Nan
2015-01-09 9:47 ` Jon Medhurst (Tixy)
2015-01-09 9:50 ` Wang Nan [this message]
2015-01-09 2:28 ` [PATCH v19 " Wang Nan
2015-01-05 11:29 ` [PATCH v19 02/11] ARM: kprobes: remove unused ARM decoder actions Wang Nan
2015-01-07 11:50 ` Jon Medhurst (Tixy)
2015-01-05 11:29 ` [PATCH v19 03/11] ARM: kprobes: introduces checker Wang Nan
2015-01-05 11:29 ` [PATCH v19 04/11] ARM: kprobes: collects stack consumption for store instructions Wang Nan
2015-01-05 11:29 ` [PATCH v19 05/11] ARM: kprobes: disallow probing stack consuming instructions Wang Nan
2015-01-05 11:29 ` [PATCH v19 06/11] ARM: kprobes: Add test cases for " Wang Nan
2015-01-05 11:29 ` [PATCH v19 07/11] kprobes: Pass the original kprobe for preparing optimized kprobe Wang Nan
2015-01-05 11:29 ` [PATCH v19 08/11] ARM: kprobes: enable OPTPROBES for ARM 32 Wang Nan
2015-01-07 13:01 ` Jon Medhurst (Tixy)
2015-01-09 6:37 ` [PATCH v20 " Wang Nan
2015-01-09 10:25 ` Jon Medhurst (Tixy)
2015-01-09 10:55 ` Wang Nan
2015-01-09 16:35 ` Russell King - ARM Linux
2015-01-09 17:28 ` Jon Medhurst (Tixy)
2015-01-09 17:57 ` Russell King - ARM Linux
2015-01-09 19:18 ` Jon Medhurst (Tixy)
2015-01-09 6:51 ` [PATCH v19 " Wang Nan
2015-01-05 11:29 ` [PATCH v19 09/11] ARM: kprobes: Fix unreliable MRS instruction tests Wang Nan
2015-01-05 11:29 ` [PATCH v19 10/11] ARM: kprobes: check register usage for probed instruction Wang Nan
2015-01-13 15:01 ` Jon Medhurst (Tixy)
2015-01-13 16:13 ` [PATCH] " Jon Medhurst (Tixy)
2015-01-19 10:37 ` Wang Nan
2015-01-05 11:34 ` [PATCH v19 11/11] ARM: optprobes: execute instruction during restoring if possible Wang Nan
2015-01-07 13:40 ` [PATCH v19 00/11] ARM: kprobes: OPTPROBES and other improvements Jon Medhurst (Tixy)
2015-01-20 2:17 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AFA44D.1080500@huawei.com \
--to=wangnan0@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox