From: voice.shen@atmel•com (Bo Shen)
To: linux-arm-kernel@lists•infradead.org
Subject: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning
Date: Tue, 13 Jan 2015 17:33:12 +0800 [thread overview]
Message-ID: <54B4E658.8070506@atmel.com> (raw)
In-Reply-To: <54B4DDC9.2000902@metafoo.de>
Hi Lars-Peter Clausen,
On 01/13/2015 04:56 PM, Lars-Peter Clausen wrote:
> On 01/13/2015 06:36 AM, Bo Shen wrote:
>> Hi Lars-Perter Clausen,
>>
>> On 01/12/2015 05:30 PM, Lars-Peter Clausen wrote:
>>> On 01/12/2015 04:32 AM, Bo Shen wrote:
>>> [...]
>>>>>> diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
>>>>>> index 4d2d2b1..38582d7 100644
>>>>>> --- a/sound/soc/codecs/wm8904.c
>>>>>> +++ b/sound/soc/codecs/wm8904.c
>>>>>> @@ -1076,10 +1076,10 @@ static const struct snd_soc_dapm_route
>>>>>> adc_intercon[] = {
>>>>>> { "Right Capture PGA", NULL, "Right Capture Mux" },
>>>>>> { "Right Capture PGA", NULL, "Right Capture Inverting Mux" },
>>>>>>
>>>>>> - { "AIFOUTL", "Left", "ADCL" },
>>>>>> - { "AIFOUTL", "Right", "ADCR" },
>>>>>> - { "AIFOUTR", "Left", "ADCL" },
>>>>>> - { "AIFOUTR", "Right", "ADCR" },
>>>>>> + { "AIFOUTL", NULL, "ADCL" },
>>>>>> + { "AIFOUTL", NULL, "ADCR" },
>>>>>> + { "AIFOUTR", NULL, "ADCL" },
>>>>>> + { "AIFOUTR", NULL, "ADCR" },
>>>>>
>>>>> Is this the right fix here? I am not super familiar with the
>>>>> driver but it appears to contain an "AIFOUTL Mux" control which
>>>>> is not connected to anything. Looks like maybe this is a mistake
>>>>> the mux is indeded to be included in the path? Feels like we
>>>>> should either remove the control as well or hook it into the
>>>>> path.
>>>>
>>>> Thank for your information.
>>>> I think here it should correct the path name as
>>>> --->8---
>>>> { "AIFOUTL Mux", "Left", "ADCL" },
>>>> { "AIFOUTL Mux", "Right", "ADCR" },
>>>> { "AIFOUTR Mux", "Left", "ADCL" },
>>>> { "AIFOUTR Mux", "Right", "ADCR" },
>>>> ---8<---
>>>>
>>>> Thanks again. I will send out the new version.
>>>
>>> Your probably also need to connect the mux to the output pins.
>>
>> Thanks for you information, after check the datasheet, I still don't know
>> which the mux should connect to which output pins.
>
> AIFOUTL Mux to AIFOUTL
> AIFOUTR Mux to AIFOUTR
Thanks. I will send new version patch for review.
Best Regards,
Bo Shen
prev parent reply other threads:[~2015-01-13 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 8:53 [PATCH] ASoC: wm8904: fix runtime warning Bo Shen
2015-01-09 11:16 ` [alsa-devel] " Charles Keepax
2015-01-12 3:32 ` Bo Shen
2015-01-12 9:30 ` Lars-Peter Clausen
2015-01-13 5:36 ` Bo Shen
2015-01-13 8:56 ` Lars-Peter Clausen
2015-01-13 9:33 ` Bo Shen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B4E658.8070506@atmel.com \
--to=voice.shen@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox