From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/8] device core: Introduce per-device MSI domain pointer
Date: Fri, 16 Jan 2015 19:10:22 +0000 [thread overview]
Message-ID: <54B9621E.5080209@arm.com> (raw)
In-Reply-To: <CALRxmdDVUoYNg3QC0LdvKmCz9x4nzE9+TDiV9K9OH=Gxk-Cd9w@mail.gmail.com>
Hi Stuart,
On 15/01/15 20:35, Stuart Yoder wrote:
> On Thu, Jan 8, 2015 at 11:06 AM, Marc Zyngier <marc.zyngier@arm•com> wrote:
>> As MSI-type features are creeping into non-PCI devices, it is
>> starting to make sense to give our struct device some form of
>> support for this, by allowing a pointer to an MSI irq domain to
>> be set/retrieved.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm•com>
>> ---
>> include/linux/device.h | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/include/linux/device.h b/include/linux/device.h
>> index fb50673..ec4cee5 100644
>> --- a/include/linux/device.h
>> +++ b/include/linux/device.h
>> @@ -690,6 +690,7 @@ struct acpi_dev_node {
>> * along with subsystem-level and driver-level callbacks.
>> * @pins: For device pin management.
>> * See Documentation/pinctrl.txt for details.
>> + * @msi_domain: The generic MSI domain this device is using.
>> * @numa_node: NUMA node this device is close to.
>> * @dma_mask: Dma mask (if dma'ble device).
>> * @coherent_dma_mask: Like dma_mask, but for alloc_coherent mapping as not all
>> @@ -750,6 +751,9 @@ struct device {
>> struct dev_pm_info power;
>> struct dev_pm_domain *pm_domain;
>>
>> +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
>> + struct irq_domain *msi_domain; /* MSI domain device uses */
>> +#endif
>
> This is not a comment on this patch specifically, but a question about other
> MSI specific fields that might be needed in struct device.
>
> Currently the generic MSI domain handling has hardcoded assumptions
> that devices are PCI-- see the for_each_msi_entry() iterator in msi.h:
>
> #define dev_to_msi_list(dev) (&to_pci_dev((dev))->msi_list)
>
> #define for_each_msi_entry(desc, dev) \
> list_for_each_entry((desc), dev_to_msi_list((dev)), list)
>
> One approach would be to move the msi_list out of pci_dev and put
> it in struct device, so all devices can have an msi_list.
>
> The other approach would be to keep msi_list in a bus specific
> device struct, and then dev_to_msi_list() would need to be
> implemented as a bus specific callback of some kind.
>
> The above hardcoded PCI assumption isn't going to work. Wanted to
> see if there is any advice in which direction to go.
The question is: can we define a generic msi_desc? If yes, then your
first proposal make sense. If not, then it is the second one.
My hunch is that we'll have to move to a model that would look like this:
struct mybus_msi_desc {
struct msi_desc desc;
struct mybus_stuff stuff;
};
and move the PCI-specific stuff out of msi_desc.
Thoughts?
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2015-01-16 19:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 17:06 [PATCH v2 0/8] Introducing per-device MSI domain Marc Zyngier
2015-01-08 17:06 ` [PATCH v2 1/8] device core: Introduce per-device MSI domain pointer Marc Zyngier
2015-01-15 20:35 ` Stuart Yoder
2015-01-16 19:10 ` Marc Zyngier [this message]
2015-01-19 2:10 ` Jiang Liu
2015-01-20 17:17 ` Stuart Yoder
2015-01-21 1:34 ` Jiang Liu
2015-01-08 17:06 ` [PATCH v2 2/8] PCI/MSI: Add hooks to populate the msi_domain field Marc Zyngier
2015-01-13 12:34 ` Yijing Wang
2015-01-13 13:45 ` Marc Zyngier
2015-01-14 2:04 ` Yijing Wang
2015-01-14 2:06 ` Yijing Wang
2015-01-08 17:06 ` [PATCH v2 3/8] PCI/MSI: of: Add support for OF-provided msi_domain Marc Zyngier
2015-01-14 8:17 ` Yun Wu (Abel)
2015-01-14 10:19 ` Marc Zyngier
2015-01-08 17:06 ` [PATCH v2 4/8] PCI/MSI: of: Allow msi_domain lookup using the PHB node Marc Zyngier
2015-01-08 17:06 ` [PATCH v2 5/8] PCI/MSI: Let pci_msi_get_domain use struct device's msi_domain Marc Zyngier
2015-01-08 17:06 ` [PATCH v2 6/8] irqchip: GICv2m: Get rid of struct msi_controller Marc Zyngier
2015-01-08 17:06 ` [PATCH v2 7/8] irqchip: gicv3-its: " Marc Zyngier
2015-01-08 17:06 ` [PATCH v2 8/8] PCI/MSI: Drop domain field from msi_controller Marc Zyngier
2015-01-27 0:45 ` [PATCH v2 0/8] Introducing per-device MSI domain Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B9621E.5080209@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox