From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv3 1/2] USB: gadget: atmel_usba_udc: Fixed vbus_prev initial state
Date: Mon, 19 Jan 2015 15:09:44 +0100 [thread overview]
Message-ID: <54BD1028.20303@atmel.com> (raw)
In-Reply-To: <1421601875-9436-2-git-send-email-sylvain.rochet@finsecur.com>
Le 18/01/2015 18:24, Sylvain Rochet a ?crit :
> If vbus gpio is high at init, we should set vbus_prev to true
> accordingly to the current vbus state. Without that, we skip the first
> vbus interrupt because the saved vbus state is not consistent.
>
> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur•com>
Indeed:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel•com>
We can also add the following tags:
Fixes: 914a3f3b3754 ("USB: add atmel_usba_udc driver")
Cc: <stable@vger•kernel.org> # 2.6.x-ish
Bye,
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index ce88237..e207d75 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1791,6 +1791,8 @@ static int atmel_usba_start(struct usb_gadget *gadget,
> toggle_bias(1);
> usba_writel(udc, CTRL, USBA_ENABLE_MASK);
> usba_writel(udc, INT_ENB, USBA_END_OF_RESET);
> +
> + udc->vbus_prev = 1;
> }
> spin_unlock_irqrestore(&udc->lock, flags);
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-01-19 14:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 22:21 [PATCH] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change Sylvain Rochet
2015-01-17 1:42 ` Alexandre Belloni
2015-01-17 9:43 ` Boris Brezillon
2015-01-17 11:07 ` Sylvain Rochet
2015-01-18 14:51 ` [PATCHv2 0/2] " Sylvain Rochet
2015-01-18 14:51 ` [PATCHv2 1/2] USB: gadget: atmel_usba_udc: Fixed vbus_prev initial state Sylvain Rochet
2015-01-18 14:51 ` [PATCH 2/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change Sylvain Rochet
2015-01-18 16:56 ` Boris Brezillon
2015-01-18 17:24 ` [PATCHv3 0/2] " Sylvain Rochet
2015-01-18 17:24 ` [PATCHv3 1/2] USB: gadget: atmel_usba_udc: Fixed vbus_prev initial state Sylvain Rochet
2015-01-19 14:09 ` Nicolas Ferre [this message]
2015-01-19 18:55 ` Felipe Balbi
2015-01-20 11:02 ` Sylvain Rochet
2015-01-20 11:11 ` Nicolas Ferre
2015-01-18 17:24 ` [PATCHv3 2/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change Sylvain Rochet
2015-01-19 16:55 ` Nicolas Ferre
2015-01-19 17:46 ` Sylvain Rochet
2015-01-19 20:15 ` Boris Brezillon
2015-01-20 9:02 ` Nicolas Ferre
2015-01-18 17:34 ` [PATCH " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD1028.20303@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox