From: s.nawrocki@samsung•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [alsa-devel] [PATCH v2 3/3] ARM: dts: Add sound nodes for exynos4412-trats2
Date: Wed, 21 Jan 2015 17:23:21 +0100 [thread overview]
Message-ID: <54BFD279.7080604@samsung.com> (raw)
In-Reply-To: <1421660902-29679-4-git-send-email-ideal.song@samsung.com>
Hi,
On 19/01/15 10:48, Inha Song wrote:
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> + sound {
> + compatible = "samsung,trats2-audio";
> + assigned-clocks = <&pmu_system_controller 0>;
> + assigned-clock-parents = <&clock CLK_XUSBXTI>;
How about putting these properties in the pmu_system_controller
node? After all the mux clock being configured here belongs to
the PMU subsystem. Wouldn't it work that way ?
> + samsung,i2s-controller = <&i2s0>;
> + samsung,model = "Trats2";
> + samsung,audio-codec = <&wm1811>;
> + samsung,audio-routing =
> + "SPK", "SPKOUTLN",
> + "SPK", "SPKOUTLP",
> + "SPK", "SPKOUTRN",
> + "SPK", "SPKOUTRP";
> + };
--
Regards,
Sylwester
next prev parent reply other threads:[~2015-01-21 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 9:48 [alsa-devel] [PATCH v2 0/3] Sound support for Exynos4412 Trats2 board Inha Song
2015-01-19 9:48 ` [alsa-devel] [PATCH v2 1/3] ASoC: samsung: Add machine driver for Trats2 Inha Song
2015-01-19 9:48 ` [alsa-devel] [PATCH v2 2/3] ASoC: samsung: Document Trats2 audio subsystem bindings Inha Song
2015-01-19 9:48 ` [alsa-devel] [PATCH v2 3/3] ARM: dts: Add sound nodes for exynos4412-trats2 Inha Song
2015-01-21 16:23 ` Sylwester Nawrocki [this message]
2015-01-22 1:18 ` Inha Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BFD279.7080604@samsung.com \
--to=s.nawrocki@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox