From: pramod.gurav@smartplayin•com (Pramod Gurav)
To: linux-arm-kernel@lists•infradead.org
Subject: [Patch v2 1/2] dmaengine: Add ADM driver
Date: Fri, 30 Jan 2015 17:17:51 +0530 [thread overview]
Message-ID: <54CB6F67.9080600@smartplayin.com> (raw)
In-Reply-To: <1420687572-7116-2-git-send-email-agross@codeaurora.org>
Hi Andy,
A minor doubt.
On Thursday 08 January 2015 08:56 AM, Andy Gross wrote:
> Signed-off-by: Andy Gross <agross@codeaurora•org>
> ---
> drivers/dma/Kconfig | 10 +
> drivers/dma/Makefile | 1 +
> drivers/dma/qcom_adm.c | 899 ++++++++++++++++++++++++++++++++++++++++++++++++
<snip>
> +
> + return ret;
> +}
> +
> +static struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec,
> + struct of_dma *of)
> +{
> + struct adm_device *adev = container_of(of->of_dma_data,
> + struct adm_device, common);
> + struct adm_chan *achan;
I don't see achan being used anywhere in this function? apart from below.
> + struct dma_chan *chan;
> + unsigned int request;
> +
> + if (dma_spec->args_count != 1) {
> + dev_err(adev->dev, "incorrect number of dma arguments\n");
> + return NULL;
> + }
> +
> + request = dma_spec->args[0];
> + if (request >= adev->num_channels)
> + return NULL;
> +
> + chan = dma_get_slave_channel(&(adev->channels[request].vc.chan));
> +
> + if (!chan)
> + return NULL;
> +
> + achan = to_adm_chan(chan);
Could not understand the use of achan here. unused code?
> +
> + return chan;
> +}
> +
> +/**
> + * adm_issue_pending - starts pending transactions
> + * @chan: dma channel
<snip>
> +module_platform_driver(adm_dma_driver);
> +
> +MODULE_AUTHOR("Andy Gross <agross@codeaurora•org>");
> +MODULE_DESCRIPTION("QCOM ADM DMA engine driver");
> +MODULE_LICENSE("GPL v2");
>
next prev parent reply other threads:[~2015-01-30 11:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 3:26 [Patch v2 0/2] Add Qualcomm ADM dmaengine driver Andy Gross
2015-01-08 3:26 ` [Patch v2 1/2] dmaengine: Add ADM driver Andy Gross
2015-01-08 3:36 ` Andy Gross
2015-01-09 4:38 ` Archit Taneja
2015-01-09 17:08 ` Andy Gross
2015-01-30 11:47 ` Pramod Gurav [this message]
2015-02-11 5:20 ` Andy Gross
2015-01-08 3:26 ` [Patch v2 2/2] dt/bindings: qcom_adm: Fix channel specificers Andy Gross
2015-01-08 16:26 ` Christopher Covington
2015-01-08 17:19 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CB6F67.9080600@smartplayin.com \
--to=pramod.gurav@smartplayin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox