Subject: [PATCH] ARM: shmobile: silk: initial device tree

From: [email-masked] (Sergei Shtylyov)
Date: Mon, 02 Feb 2015 23:57:50 +0300

Hello.

On 02/02/2015 02:05 PM, Mark Rutland wrote:

>> Add the initial device tree for the R8A7794 SoC based SILK low cost board.
>> SCIF2 serial port support is included, so that the serial console can work.

>> Signed-off-by: Sergei Shtylyov <[email-masked]>

[...]

>> Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts
>> ===================================================================
>> --- /dev/null
>> +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts
>> @@ -0,0 +1,41 @@
>> +/*
>> + * Device Tree Source for the SILK board
>> + *
>> + * Copyright (C) 2014 Renesas Electronics Corporation
>> + * Copyright (C) 2014-2015 Renesas Solutions Corp.
>> + * Copyright (C) 2014-2015 Cogent Embedded, Inc.
>> + *
>> + * This file is licensed under the terms of the GNU General Public License
>> + * version 2.  This program is licensed "as is" without any warranty of any
>> + * kind, whether express or implied.
>> + */
>> +
>> +/dts-v1/;
>> +#include "r8a7794.dtsi"
>> +
>> +/ {
>> +	model = "SILK";

> Shouldn't that have a "Renesas" prefix or something like that?

    Historically. no SH-Mobile .dts has used the vendor name in the "model" 
prop. I defer the decision to Simon but I think we should be at least consistent.

> It's unlikely that there will be another board called "SILK", but it
> does make it hard for someone to get an idea of what the board is from
> the model string alone.

    Tend to agree here.

> Mark.

WBR, Sergei