From: wangnan0@huawei•com (Wang Nan)
To: linux-arm-kernel@lists•infradead.org
Subject: arm: kprobe compilation error
Date: Tue, 10 Feb 2015 16:28:17 +0800 [thread overview]
Message-ID: <54D9C121.3000601@huawei.com> (raw)
In-Reply-To: <54D8934B.6040709@elproma.com.pl>
On 2015/2/9 19:00, Janusz U?ycki wrote:
>
> W dniu 2015-02-09 o 10:44, Jon Medhurst (Tixy) pisze:
>> Hi Janusz
>>
>> On Thu, 2015-02-05 at 16:17 +0100, Janusz U?ycki wrote:
>>> I got the compilation error on next-20150204:
>>>
>> [...]
>>> In file included from arch/arm/probes/kprobes/core.c:37:
>>> arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other
>>> than a declaration
>> [...]
>>> gcc version 4.2.4
>> Thanks for reporting this, is it OK if I add to a patch to fix this a
>> line saying "Reported-by: Janusz U?ycki <j.uzycki@elproma•com.pl>"?
>
> sure
>
>>
>> Whilst the extra '*' looks like an obvious typo, it's interesting that
>> your error message implies that it's allowed in some situations and that
>> the version of GCC that I use (4.9.1) doesn't complain about it.
>> If it's valid C, I've no idea what that syntax that might represent.
>>
> I've not find such extension in C11 but likely gcc's team knows the answer.
> It also compiles using gcc 4.8.3. However I thing more people use older compilers
> for different platforms.
>
Hi All,
Thanks for reporting and fixing this.
When writing this code I checked C spec from open-std (n1548 and n1570). I got an
feeling that [*] should be a standard way to specify variable length array types.
Please see 6.7.6.3 and 6.7.7 of the spec. However I forgot there are old gccs which
don't support that standard.
Thank you!
> best regards
> Janusz
>
next prev parent reply other threads:[~2015-02-10 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 15:17 arm: kprobe compilation error Janusz Użycki
2015-02-07 7:22 ` Masami Hiramatsu
2015-02-09 9:44 ` Jon Medhurst (Tixy)
2015-02-09 11:00 ` Janusz Użycki
2015-02-10 8:28 ` Wang Nan [this message]
2015-02-10 9:36 ` Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D9C121.3000601@huawei.com \
--to=wangnan0@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox