From: s.nawrocki@samsung•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs
Date: Tue, 10 Feb 2015 15:08:42 +0100 [thread overview]
Message-ID: <54DA10EA.4010701@samsung.com> (raw)
In-Reply-To: <1423574072.6241.8.camel@AMDC1943>
On 10/02/15 14:14, Krzysztof Kozlowski wrote:
> On wto, 2015-02-10 at 14:00 +0100, Sylwester Nawrocki wrote:
>> > On 10/02/15 13:46, Javier Martinez Canillas wrote:
>>>>>> > >>>> This debugfs code iterates over list of generic_pm_domains (gpd_list). I
>>>>>>>>> > >>>> >> > cannot find function for translating from genpd to its platform device
>>>>>>>>> > >>>> >> > so only genpd->name can be printed.
>>>>>>> > >>> >>
>>>>>>> > >>> >> Then why power domains aren't just named with the platform device names?
>>>>> > >> >
>>>>> > >> > Right, the mach-exynos/pm_domains.c set the name equal to OF node name.
>>>>> > >> > I'll send a patch extending the name.
>>>>> > >> >
>>> > > IIRC the OF core uses the device node unit address and node name to create
>>> > > the platform device names so you will have something like 10044000.power-domain.
>>> > >
>>> > > Same if using the node full_name since it will /power-domain at 10044000. In both
>>> > > cases the DTS should have to be checked to know which power domain really is
>>> > > unless someone knows by heart the power domains addresses.
> For the kernel developer that would be descriptive enough to find the
> real domain but... as you said each time one would have to grep through
> manual or DTS which is slower. However for end-user that still won't be
> descriptive enough.
>
>>> > >
>>> > > But if using generic names for the power domains as suggested by ePAPR is so
>>> > > important then we should change all the other Exynos DTS files which don't do.
>> >
>> > Perhaps we could assign OF aliases to the power domain device nodes in DT
>> > and then in the power domains driver map those aliases to more descriptive
>> > names when creating the power domains?
>
> That would required additional alias in DT but it could be the most
> descriptive for a user.
Yes, we could fall back to of_node->full_name if alias is not present in DT.
--
Regards,
Sylwester
prev parent reply other threads:[~2015-02-10 14:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 17:37 [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs Javier Martinez Canillas
2015-02-06 19:09 ` Sergei Shtylyov
2015-02-06 20:50 ` Javier Martinez Canillas
2015-02-10 11:46 ` Krzysztof Kozlowski
2015-02-10 11:55 ` Sergei Shtylyov
2015-02-10 12:17 ` Krzysztof Kozlowski
2015-02-10 12:21 ` Sergei Shtylyov
2015-02-10 12:30 ` Krzysztof Kozlowski
2015-02-10 12:46 ` Javier Martinez Canillas
2015-02-10 13:00 ` Sylwester Nawrocki
2015-02-10 13:14 ` Krzysztof Kozlowski
2015-02-10 14:08 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DA10EA.4010701@samsung.com \
--to=s.nawrocki@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox