From: jonathar@broadcom•com (Jonathan Richardson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver
Date: Wed, 11 Feb 2015 10:45:34 -0800 [thread overview]
Message-ID: <54DBA34E.8090400@broadcom.com> (raw)
In-Reply-To: <54B81A4A.9020905@broadcom.com>
Pinging maintainers... Am I ok to go ahead with the current rotation
implementation? I haven't heard anything further. Any feedback on naming
conventions from DT people?
Thanks!
On 15-01-15 11:51 AM, Jonathan Richardson wrote:
> Hi Dmitry,
>
> On 15-01-14 10:07 PM, Dmitry Torokhov wrote:
>> On Wed, Jan 14, 2015 at 09:44:39PM -0800, Scott Branden wrote:
>>> On 15-01-14 05:02 PM, Dmitry Torokhov wrote:
>>>> Hi Jonathan,
>>>>
>>>> On Fri, Dec 19, 2014 at 02:17:49PM -0800, Jonathan Richardson wrote:
>>>>> + if (of_property_read_u32(np, "scanning_period", &val) >= 0) {
>>>>> + if (val < 1 || val > 256) {
>>>>> + dev_err(dev, "scanning_period must be [1-256]\n");
>>>>> + return -EINVAL;
>>>>> + }
>>>>> + priv->cfg_params.scanning_period = val;
>>>>> + }
>>>>> +
>>>>> + if (of_property_read_u32(np, "debounce_timeout", &val) >= 0) {
>>>>> + if (val < 0 || val > 255) {
>>>>> + dev_err(dev, "debounce_timeout must be [0-255]\n");
>>>>> + return -EINVAL;
>>>>> + }
>>>>> + priv->cfg_params.debounce_timeout = val;
>>>>> + }
>>>>> +
>>>>> + if (of_property_read_u32(np, "settling_timeout", &val) >= 0) {
>>>>> + if (val < 0 || val > 11) {
>>>>> + dev_err(dev, "settling_timeout must be [0-11]\n");
>>>>> + return -EINVAL;
>>>>> + }
>>>>> + priv->cfg_params.settling_timeout = val;
>>>>> + }
>>>>> +
>>>>> + if (of_property_read_u32(np, "touch_timeout", &val) >= 0) {
>>>>> + if (val < 0 || val > 255) {
>>>>> + dev_err(dev, "touch_timeout must be [0-255]\n");
>>>>> + return -EINVAL;
>>>>> + }
>>>>> + priv->cfg_params.touch_timeout = val;
>>>>> + }
>>>>> +
>>>>> + if (of_property_read_u32(np, "average_data", &val) >= 0) {
>>>>> + if (val < 0 || val > 8) {
>>>>> + dev_err(dev, "average_data must be [0-8]\n");
>>>>> + return -EINVAL;
>>>>> + }
>>>>> + priv->cfg_params.average_data = val;
>>>>> + }
>>>>> +
>>>>> + if (of_property_read_u32(np, "fifo_threshold", &val) >= 0) {
>>>>> + if (val < 0 || val > 31) {
>>>>> + dev_err(dev, "fifo_threshold must be [0-31]\n");
>>>>> + return -EINVAL;
>>>>> + }
>>>>> + priv->cfg_params.fifo_threshold = val;
>>>>> + }
>>>>
>>>> I think these are dveice specific and thus should have "brcm," prefix.
>>> I'm confused as to why we need the brcm prefix? Other device tree
>>> bindings we have for other drivers do not need such prefix.
>>
>> Properties that are not standard on the system (reg, interrupts,
>> clkocks, etc) or subsystem level customarily carry the vendor prefix so
>> that they do not clash with newly added global or subsystem properties.
>>
>>> Is this
>>> convention documented somewhere?
>>
>> Not sure. I glanced through Documentation/devicetree and do not see it
>> spelled out. Device tree overlords, what say you?
>
> Let me know. I haven't seen this before either. I will change the
> entries to use dashes though instead of underscores but will wait until
> these other issues are decided on before sending out another patch.
>
>>
>>>>
>>>>> +
>>>>> + priv->ts_rotation = TS_ROTATION_0;
>>>>> + if (of_property_read_u32(np, "ts-rotation", &val) >= 0) {
>>>>> + priv->ts_rotation = val;
>>>>> + dev_dbg(dev, "ts rotation [%d] degrees\n",
>>>>> + 90 * priv->ts_rotation);
>>>>> + }
>>>>
>>>> This I am not quite sure about - if we want rotation or swap+invert. You
>>>> are CCed on another email (tsc2007) that talks about need of generic
>>>> touchscreen transforms in input core/of bindings.
>>> Does such generic binding exist today? If not, I would like to go
>>> with this implementation and update to the new binding if/when it
>>> exists?
>>
>> Not yet but there several people interested. I think we have enough time
>> till 3.20 to hash it out properly.
>
> I think the rotation is simpler personally. Everyone would understand
> rotation refers to how it's oriented but I'm not sure everyone would
> immediately know how it is wired. Let me know what is decided and I'll
> make any changes required.
>
> Thanks,
> Jon
>
>
>>
>> Thanks.
>>
>
next prev parent reply other threads:[~2015-02-11 18:45 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Jonathan Richardson <jonathar@broadcom.com>
2014-09-16 19:58 ` [PATCH 0/6] Add initial support for Broadcom Cygnus SoC Jonathan Richardson
2014-09-16 19:58 ` [PATCH 1/6] ARM: cygnus: Initial " Jonathan Richardson
2014-09-17 0:00 ` Mark Rutland
2014-09-18 23:33 ` Jonathan Richardson
2014-09-16 19:58 ` [PATCH 2/6] clk: Clock driver " Jonathan Richardson
2014-09-17 0:47 ` Mark Rutland
2014-09-18 23:43 ` Jonathan Richardson
2014-09-16 19:58 ` [PATCH 3/6] dt-bindings: Document Broadcom Cygnus SoC and clock driver Jonathan Richardson
2014-09-16 19:58 ` [PATCH 4/6] ARM: dts: Enable Broadcom Cygnus SoC Jonathan Richardson
2014-09-16 19:58 ` [PATCH 5/6] ARM: cygnus defconfig : Initial defconfig for " Jonathan Richardson
2014-09-16 19:58 ` [PATCH 6/6] MAINTAINERS: Entry for Cygnus/iproc arm architecture and clock drivers Jonathan Richardson
2014-09-18 22:31 ` [PATCH 0/6] Add initial support for Broadcom Cygnus SoC Hauke Mehrtens
2014-09-18 22:39 ` Florian Fainelli
2014-09-18 22:54 ` Hauke Mehrtens
2014-09-19 0:58 ` Scott Branden
2014-09-23 21:17 ` [PATCH v2 " Jonathan Richardson
2014-09-23 21:17 ` [PATCH v2 1/6] ARM: cygnus: Initial " Jonathan Richardson
2014-09-23 21:17 ` [PATCH v2 2/6] clk: Clock driver " Jonathan Richardson
2014-09-23 21:17 ` [PATCH v2 3/6] dt-bindings: Document Broadcom Cygnus SoC and clock driver Jonathan Richardson
2014-09-23 21:17 ` [PATCH v2 4/6] ARM: dts: Enable Broadcom Cygnus SoC Jonathan Richardson
2014-09-23 21:17 ` [PATCH v2 5/6] ARM: cygnus defconfig : Initial defconfig for " Jonathan Richardson
2014-09-23 21:17 ` [PATCH v2 6/6] MAINTAINERS: Entry for Cygnus/iproc arm architecture and clock drivers Jonathan Richardson
2014-09-25 21:04 ` [PATCH v2 0/6] Add initial support for Broadcom Cygnus SoC Scott Branden
2014-09-25 21:22 ` Florian Fainelli
2014-09-26 0:14 ` Florian Fainelli
2014-09-26 0:28 ` Jonathan Richardson
2014-09-26 0:34 ` Florian Fainelli
2014-12-18 1:59 ` [PATCH 0/2] Add support for Broadcom iProc touchscreen Jonathan Richardson
2014-12-18 1:59 ` [PATCH 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver Jonathan Richardson
2014-12-18 2:14 ` Joe Perches
2014-12-19 19:51 ` Jonathan Richardson
2014-12-19 19:56 ` Dmitry Torokhov
2014-12-18 1:59 ` [PATCH 2/2] Input: touchscreen-iproc: add device tree bindings Jonathan Richardson
2014-12-19 22:17 ` [PATCH v2 0/2] Add support for Broadcom iProc touchscreen Jonathan Richardson
2014-12-19 22:17 ` [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver Jonathan Richardson
2014-12-19 22:26 ` Joe Perches
2014-12-19 23:03 ` Jonathan Richardson
2015-01-01 0:55 ` Jonathan Richardson
2015-01-15 1:08 ` Florian Fainelli
2015-01-15 19:19 ` Jonathan Richardson
2015-01-15 1:02 ` Dmitry Torokhov
2015-01-15 5:44 ` Scott Branden
2015-01-15 6:07 ` Dmitry Torokhov
2015-01-15 19:51 ` Jonathan Richardson
2015-02-11 18:45 ` Jonathan Richardson [this message]
2015-02-24 23:18 ` Dmitry Torokhov
2015-02-27 1:02 ` Jonathan Richardson
2015-02-24 23:29 ` Dmitry Torokhov
2015-03-02 19:13 ` Jonathan Richardson
2014-12-19 22:17 ` [PATCH v2 2/2] Input: touchscreen-iproc: add device tree bindings Jonathan Richardson
2015-02-24 19:13 ` [PATCH 0/1] Enable Broadcom Cygnus BCM958305K Jonathan Richardson
2015-02-24 19:13 ` [PATCH 1/1] ARM: dts: " Jonathan Richardson
2015-03-02 22:41 ` [PATCH RESEND 0/1] " Jonathan Richardson
2015-03-02 22:41 ` [PATCH RESEND 1/1] ARM: dts: " Jonathan Richardson
2015-03-02 23:45 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DBA34E.8090400@broadcom.com \
--to=jonathar@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox