From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/6] ASoC: max98088: Add DT bindings
Date: Wed, 18 Feb 2015 22:08:44 +0300 [thread overview]
Message-ID: <54E4E33C.9040301@cogentembedded.com> (raw)
In-Reply-To: <1424283959-16289-3-git-send-email-afaerber@suse.de>
Hello.
On 02/18/2015 09:25 PM, Andreas F?rber wrote:
> "maxim,max98089" will be used for the Spring Chromebook.
> Signed-off-by: Andreas F?rber <afaerber@suse•de>
> ---
> sound/soc/codecs/max98088.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
> diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
> index 805b3f8cd39d..69a21d1946e3 100644
> --- a/sound/soc/codecs/max98088.c
> +++ b/sound/soc/codecs/max98088.c
> @@ -2009,10 +2009,18 @@ static const struct i2c_device_id max98088_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, max98088_i2c_id);
>
> +static const struct of_device_id max98088_of_match[] = {
If I don't mistake, gcc will complain about this variable being unused if
CONFIG_OF=n.
> + { .compatible = "maxim,max98088" },
> + { .compatible = "maxim,max98089" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, max98088_of_match);
> +
> static struct i2c_driver max98088_i2c_driver = {
> .driver = {
> .name = "max98088",
> .owner = THIS_MODULE,
> + .of_match_table = of_match_ptr(max98088_of_match),
You probably don;t need of_match_ptr(). Either that or do something with
the match table, like enclosing into #ifdef or annotating with '__maybe_unused'.
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-02-18 19:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 18:25 [PATCH 0/6] ASoC: samsung: Spring sound support Andreas Färber
2015-02-18 18:25 ` [PATCH 1/6] ASoC: max98088: Document DT bindings Andreas Färber
2015-02-19 13:55 ` Javier Martinez Canillas
2015-02-19 14:13 ` Andreas Färber
2015-02-19 17:48 ` Doug Anderson
2015-02-19 18:40 ` Andreas Färber
2015-02-19 18:54 ` Andreas Färber
2015-02-19 20:48 ` Javier Martinez Canillas
2015-02-20 0:36 ` Andreas Färber
2015-02-20 12:12 ` Sylwester Nawrocki
2015-02-23 16:46 ` Javier Martinez Canillas
2015-02-18 18:25 ` [PATCH 2/6] ASoC: max98088: Add " Andreas Färber
2015-02-18 19:08 ` Sergei Shtylyov [this message]
2015-02-18 19:17 ` Andreas Färber
2015-02-19 19:18 ` [PATCH] ASoC: max98088: Add master clock handling Andreas Färber
2015-02-20 3:27 ` [alsa-devel] " Tushar Behera
2015-02-23 8:29 ` Javier Martinez Canillas
2015-02-23 12:23 ` Andreas Färber
2015-02-18 18:25 ` [PATCH 3/6] ARM: dts: Add max98089 to exynos5250-spring Andreas Färber
2015-02-18 18:25 ` [PATCH 4/6] ASoC: samsung: Document binding for max98089 based Snow driver Andreas Färber
2015-02-19 3:49 ` [alsa-devel] " Tushar Behera
2015-02-18 18:25 ` [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089 Andreas Färber
2015-02-19 9:44 ` Mark Brown
2015-02-19 12:33 ` Andreas Färber
2015-02-19 17:44 ` Doug Anderson
2015-02-19 17:56 ` Andreas Färber
2015-02-19 19:01 ` Doug Anderson
2015-02-21 2:40 ` Mark Brown
2015-02-18 18:25 ` [PATCH 6/6] ARM: dts: Add sound support to exynos5250-spring Andreas Färber
2015-02-19 14:05 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E4E33C.9040301@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox