From: linux@roeck-us•net (Guenter Roeck)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: Kirkwood: enable GPIO fan alarm support for 2Big Network v2
Date: Mon, 23 Feb 2015 06:10:59 -0800 [thread overview]
Message-ID: <54EB34F3.4000500@roeck-us.net> (raw)
In-Reply-To: <1424696523-14855-1-git-send-email-simon.guinot@sequanux.org>
On 02/23/2015 05:02 AM, Simon Guinot wrote:
> On the LaCie 2Big Network v2 (net2big_v2) board, the fan alarm is not
> wired to the I2C fan controller but to a separe GPIO. This GPIO can be
> controlled by using the gpio-fan driver.
>
> This patch adds the gpio-fan alarm description in the net2big_v2 DTS.
>
> Signed-off-by: Simon Guinot <simon.guinot@sequanux•org>
> ---
> arch/arm/boot/dts/kirkwood-net2big.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-net2big.dts b/arch/arm/boot/dts/kirkwood-net2big.dts
> index 53dc37a3b687..e4f7e497379f 100644
> --- a/arch/arm/boot/dts/kirkwood-net2big.dts
> +++ b/arch/arm/boot/dts/kirkwood-net2big.dts
> @@ -27,6 +27,11 @@
> device_type = "memory";
> reg = <0x00000000 0x10000000>;
> };
> +
> + gpio_fan {
> + compatible = "gpio-fan";
> + alarm-gpios = <&gpio0 25 GPIO_ACTIVE_LOW>;
> + };
> };
>
> ®ulators {
>
Again, wrong solution, and conceptually wrong as well from a dt perspective.
The alarm signal should be handled by the g762 driver, and the alarm-gpios
property should be added to the g762 description.
Guenter
next prev parent reply other threads:[~2015-02-23 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 13:02 [PATCH] ARM: Kirkwood: enable GPIO fan alarm support for 2Big Network v2 Simon Guinot
2015-02-23 14:10 ` Guenter Roeck [this message]
2015-02-23 14:40 ` Simon Guinot
2015-02-23 14:49 ` Guenter Roeck
2015-02-25 12:36 ` Simon Guinot
2015-02-25 14:31 ` Guenter Roeck
2015-02-25 15:01 ` Simon Guinot
2015-02-25 16:27 ` Guenter Roeck
2015-02-23 15:35 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EB34F3.4000500@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox